From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.smtpout.orange.fr (smtp-12.smtpout.orange.fr [80.12.242.12]) by sourceware.org (Postfix) with ESMTPS id 2F1CC38518A6 for ; Mon, 21 Nov 2022 18:24:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2F1CC38518A6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orange.fr Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=orange.fr Received: from [192.168.1.17] ([2.10.193.163]) by smtp.orange.fr with ESMTPA id xBSyot5lNap0YxBSyoOfcQ; Mon, 21 Nov 2022 19:24:30 +0100 X-ME-Helo: [192.168.1.17] X-ME-Auth: bW9yaW4tbWlrYWVsQG9yYW5nZS5mcg== X-ME-Date: Mon, 21 Nov 2022 19:24:30 +0100 X-ME-IP: 2.10.193.163 Message-ID: <4ac33f88-c3bf-91d2-aa8d-be936676b679@orange.fr> Date: Mon, 21 Nov 2022 19:24:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/2] symtab: also change RTL decl name Content-Language: fr, en-US To: Bernhard Reutner-Fischer , gcc-patches@gcc.gnu.org, Jan Hubicka Cc: Bernhard Reutner-Fischer , gfortran ML References: <20221109190225.96037-1-aldot@gcc.gnu.org> <20221109190225.96037-2-aldot@gcc.gnu.org> <20221117090219.2884af08@nbbrfq> From: Mikael Morin In-Reply-To: <20221117090219.2884af08@nbbrfq> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,FREEMAIL_FROM,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Le 17/11/2022 à 09:02, Bernhard Reutner-Fischer via Fortran a écrit : > Hi Honza, Ping. > Regtests cleanly for c,fortran,c++,ada,d,go,lto,objc,obj-c++ > Ok? > I'd need this for attribute target_clones for the Fortran FE. > thanks, > > On Wed, 9 Nov 2022 20:02:24 +0100 > Bernhard Reutner-Fischer wrote: > >> We were changing the ASSEMBLER_NAME of the function decl >> but not the name in DECL_RTL which is used as the function name >> fnname in rest_of_handle_final(). This led to using the old, wrong name >> for the attribute target default function when using target_clones. >> >> Bootstrapped and regtested cleanly on x86_64-unknown-linux >> for c,c++,fortran,lto. >> Ok for trunk? >> >> gcc/ChangeLog: >> >> * symtab.cc: Remove stray comment. >> (symbol_table::change_decl_assembler_name): Also update the >> name in DECL_RTL. >> (patch stripped) Is there a PR about this? Or a testcase exhibiting the problem at least?