Hi Tobias,

Please see the updated patch attached incorporating your input and 
details below.

On 24/10/2023 18:12, you wrote:
> On 20.10.23 16:02, Paul-Antoine Arras wrote:
>> gcc/fortran/ChangeLog:
>>
>>       * interface.cc (gfc_compare_types): Return true in this situation.
> 
> That's a bad description. It makes sense when reading the commit log but 
> if you
> only read gcc/fortran/ChangeLog, 'this situation' is a dangling reference.

Updated Changelog with a more helpful description.

>>   gcc/fortran/ChangeLog.omp                    |  5 ++
>>   gcc/testsuite/ChangeLog.omp                  |  4 ++
> 
> On mainline, the ChangeLog not ChangeLog.omp is used. This changelog is 
> automatically
> filled by the data in the commit log. Thus, no need to include it in the 
> patch.

Removed ChangeLog.omp from the patch.

> See attached patch for a combined version, which checks now
> whether from_intmod == INTMOD_ISO_C_BINDING and then compares
> the names (to distinguish c_ptr and c_funptr). Those are unaffected
> by 'use' renames, hence, we should be fine.

Added the proposed diff for interface.cc and misc.cc to the patch.

> Additionally, I think it would be good to have a testcase which checks for
>    c_funptr vs. c_ptr
> mismatch.

Added new testcase c_ptr_tests_21.f90 to check that incompatibilities 
between c_funptr vs. c_ptr are properly reported.

Is this latest revision ready to commit?

Thanks,
-- 
PA