From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 621863858412; Sat, 6 May 2023 18:15:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 621863858412 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1683396943; i=anlauf@gmx.de; bh=RHMt6JyBirft+sl8K45dqkc5lU+t85aaoR4xvJ/uW+4=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=LO8xN9YXp7jI1KP9mjKRhCzwchFZMwk/zKX0I97GJ9jKJc/kSXePfi0iJLeVag/m6 NNfDWgUXAyQUqyNcWFkC08J1CtIOrwcR20lf9ecQPVN/GPG1AN0YWNDMj/2BCJQDPe +bRT0ydfJ59sPgmdbmGsscLcVjTbYOzt4GPXsjgMs6Iq4UXXnNYCmW3UOu3XwUnypX uRnJr60z6MwIg/G2EyrtDNrrs//VqGcbnq5Tv/Bg7BOqoishFm8OnjOCu5nPPPsOr2 7xvOw4u2n0Rth4cJRPkFmwwGxaM7F8LYX/MwYt6QCaoAUriPDuYLL5uh96pbm+nlls fCCGjwghS8I0Q== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([79.232.155.135]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MOiDX-1paEeu1ki7-00QFPJ; Sat, 06 May 2023 20:15:43 +0200 Message-ID: <508ee742-97fa-9f61-ab65-98d3fa8e7dca@gmx.de> Date: Sat, 6 May 2023 20:15:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [patch, fortran] PR109662 Namelist input with comma after name accepted To: sgk@troutmask.apl.washington.edu, Jerry D via Fortran Cc: gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: Content-Language: en-US From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:UNyTstZwvM9+J0EQeCFHABPOyhQkMuw97EWrXAGeC7Fy8zGHsx1 C5A+4bqC80I0O2+Jzlr/8HBC9Ou6aC7yRsJp8xq5YhoDKVqby43DaRDB/11c5J8I39mfVmF Nle0EV23aIRrZ4casv1EscEtbLPQ6Uj2bVkLIedQCWuRzgEfbG8HC6+kuRvn/G+ZV7ln7IU MnhQA1jQqH3ZyWbdpJ8PQ== UI-OutboundReport: notjunk:1;M01:P0:I3fO/SFTc1o=;EiHR5xyF3pWz5ERYKkOMcjqyLhI zH0tfnPdEkO2I5G4D2I1irlrWZvuPJOWaEMkVgPtrbg/cpqMIsZX+rWJF3HfEScYZLk5XheA4 MN198OuXMjrUM46WyOxnYbXAn3H8Z/0FRzcjns60nGaF7q7p8eX9HTRxm5NKx3PklsBuA0TlN n3sGT6Cx8/JOQu2/GroPrTMJnan1z9Dhel/Y8tzTlNIzixS00yz2PueIUNNnSsa0m1woTXBOn gB/cfVBdjRXjj9Zek56cZ0HyIHOvZP1NFsr7NKfMLndit/3tyDvZo2j16tWIM2koczZPN/SLF FCNUKnfk8Gi+tsxT7l1NzxNRueaD/pvNfuvK8OWy5WC2MwoLAhcRAC8bcz6qFyDHqTF94jtw0 +2lq4sIe5YNVhpvV0rlRlcJZH/PMTJ8s18dn4ZAp+VdnXsqnIu3gyEu/AE9FVL0ZYsR/UZNx/ /qXmRg2ox1Zv2TdT6NXu15GIGua3xVsRe5urcR3o79j4ay3dQWQWXHaTxkY/bA9DWLy6emROW QR0E3cdoG93/VJla+j3fc7zpEJkLgrxWnJbFnIfZW+yIkkVrmKs7TDz2wxGs4UAiQDNX4yVS+ WmGt3eLeglsOWn3RzDvy1lD3kIcHc/fW+ITTEjbB2ECBlKWtWigXe3Am15AXNxgoloBLDy/yb oOfMWUUefAkLRXDqfpi3xxT2RY1mfeSpmj0tqycnfIkd97bqSSwcuLhTeo+0W/UqazeOnSWwt 32NvWSvBUxfL6kwOueqip47bsSdtFw5JuCZsLisFVQjNtcFlpdlr6BOubDytTHv7W/olxAzMi wPHSG68V3TA1HQuc/Y/NmCdWG41JiU85OHCNDukqa0/eocez8wtm/SP5oPLVLbmLFAEY8h+Hk 4Pe/h8TFY4Ac3zANJTxkrH7Rmw5alTRxm7mnVMLTri0KITxak+ZI85zpoID7w+dirhwRqv/81 bNqGSLMdbEIliZvdNdarA4w6nv8= X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jerry, Steve, I think I have to pour a little water into the wine. The patch fixes the reported issue only for a comma after the namelist name, but we still accept a few other illegal characters, e.g. ';', because: #define is_separator(c) (c =3D=3D '/' || c =3D=3D ',' || c =3D=3D '\n' ||= c =3D=3D ' ' \ || c =3D=3D '\t' || c =3D=3D '\r' || c =3D=3D ';= ' || \ (dtp->u.p.namelist_mode && c =3D=3D '!')) We don't want that in standard conformance mode, or do we? Cheers, Harald On 5/6/23 06:02, Steve Kargl via Gcc-patches wrote: > On Fri, May 05, 2023 at 08:41:48PM -0700, Jerry D via Fortran wrote: >> The attached patch adds a check for the invalid comma and emits a runti= me >> error if -std=3Df95,f2003,f2018 are specified at compile time. >> >> Attached patch includes a new test case. >> >> Regression tested on x86_64-linux-gnu. >> >> OK for mainline? >> > > Yes. Thanks for the fix. It's been a long time since > I looked at libgfortran code and couldn't quite determine > where to start to fix this. >