public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jerry DeLisle <jvdelisle@charter.net>
To: FX <fxcoudert@gmail.com>
Cc: gfortran <fortran@gcc.gnu.org>, gcc patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] PR52393 I/O: "READ format" statement with parenthesized default-char-expr
Date: Wed, 01 Jun 2016 16:28:00 -0000	[thread overview]
Message-ID: <510ebfd6-3e3c-c75b-e5d5-1328ebc28351@charter.net> (raw)
In-Reply-To: <3F336BB9-A24D-4B1E-8E98-25DBC1246326@gmail.com>

On 06/01/2016 12:25 AM, FX wrote:
>> 2016-05-30  Jerry DeLisle  <jvdelisle@gcc.gnu.org>
>>
>> 	PR fortran/52393
>> 	* io.c (match_io): For READ, try to match a default character
>> 	expression. If found, set the dt format expression to this,
>> 	otherwise go back and try control list.
> 
> OK. Maybe you could add some “negative” tests too? To be sure we still catch malformed parenthesized formats?
> 
> FX
> 

Thanks for review!  yes I will add some tests.

Jerry

  reply	other threads:[~2016-06-01 16:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 19:20 Jerry DeLisle
2016-06-01  7:26 ` FX
2016-06-01 16:28   ` Jerry DeLisle [this message]
2016-06-03 19:40     ` H.J. Lu
2016-06-05 22:28       ` Jerry DeLisle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=510ebfd6-3e3c-c75b-e5d5-1328ebc28351@charter.net \
    --to=jvdelisle@charter.net \
    --cc=fortran@gcc.gnu.org \
    --cc=fxcoudert@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).