From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by sourceware.org (Postfix) with ESMTPS id A67663858CD1; Fri, 23 Jun 2023 12:12:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A67663858CD1 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=acm.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-x72a.google.com with SMTP id af79cd13be357-763e968b795so46544485a.0; Fri, 23 Jun 2023 05:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687522363; x=1690114363; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=A2dV0nIqdd9LKobNWvo3xlvC9wdUZSExrpSpUDKOTPw=; b=EmFsjNC1VxmRIOb93P6x3Y60YnJFnKac9ocSakcMEYzyVhcPVmZTA4XsVhfW3bcbIC YP+0iatsbGak8ZRFtrJTp6aEDJcJxnZQ6TuGTKwu9+SqvVm9XOuEGMkwsu3LVgIj33jS WiROfQuoMS/K+JdjnRl1ORvD9CtqBDhCrK7fcZiqhRzGmQO8HgyIryfbQJ+Z8I1w2yWR dJ5sC17XCzmj5Ouu6FCN3j/1sMtEYRsrHx5zd6Ja7xcJQ+5A06rJXVSAk0yQppgWLbCn CxogPnb2+Sgp+oHSQtFBgIf1FwwvFCGpR9F4mF4M0j9Mi3OQ2ncqe2S7PGX4U5R5KFGe FqsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687522363; x=1690114363; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A2dV0nIqdd9LKobNWvo3xlvC9wdUZSExrpSpUDKOTPw=; b=CKrvd216li9zuVYyKlf/j6PCL6kM3GRj5ULyNO+sL8K3Sxc9sov7cnW3ZmEo/Z01Fu 0BTfSRvEkT8uC8I1qJRYLhDNUA7QQ1xlhvTv9fDvSNI7qYeTltZ7tCYp1C6Ohl4BbxHT 2Zc6n0HkogdnXswFbb+E3BOZ3T+tgtwqeSf1EyaiG/K5M8CGayg9AXFo1tpdtfs9zzX0 V/cakRwBOpfOpYRW1UVjK74PvMWdYcYxz11U4WRJVD+H1jiUfHyoH6harSEH4eOtctK1 GDvdNQUmCImJirvF+w9XuuHWcnKHpqiec1fZCZ6xplwdMER+3Hq7TBQ7ReTArT4IGS1b MlZg== X-Gm-Message-State: AC+VfDwhStztAPKigBxRcTXBU3ryfXvd+yGZGiTpHLL7eNl/qTjVxLoV +aLM8tEYYxuIX0a/v/XNgYk= X-Google-Smtp-Source: ACHHUZ7hpDjDYBI+RUdiTDn59gm99QAPLOAcfVvgjGNtbQuPv+Wkbl6u7iscqM3enZvibBmPGXQoKg== X-Received: by 2002:a05:620a:3955:b0:763:ae1a:2af7 with SMTP id qs21-20020a05620a395500b00763ae1a2af7mr14639481qkn.55.1687522362877; Fri, 23 Jun 2023 05:12:42 -0700 (PDT) Received: from ?IPV6:2601:19c:527f:bfd0::2? ([2601:19c:527f:bfd0::2]) by smtp.googlemail.com with ESMTPSA id c13-20020a05620a134d00b0076531707258sm1649985qkl.7.2023.06.23.05.12.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 05:12:42 -0700 (PDT) Sender: Nathan Sidwell Message-ID: <541367ff-25da-9745-d768-c60f235cd5bc@acm.org> Date: Fri, 23 Jun 2023 08:12:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v5 4/5] c++modules: report imported CMI files as dependencies Content-Language: en-US To: Ben Boeckel , Jason Merrill Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org, brad.king@kitware.com References: <20230125210636.2960049-1-ben.boeckel@kitware.com> <20230125210636.2960049-5-ben.boeckel@kitware.com> <734eef7c-f7c3-519c-e007-cb42f8dc8a82@redhat.com> <20230623024559.GA255658@farprobe> From: Nathan Sidwell In-Reply-To: <20230623024559.GA255658@farprobe> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3032.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/22/23 22:45, Ben Boeckel wrote: > On Thu, Jun 22, 2023 at 17:21:42 -0400, Jason Merrill wrote: >> On 1/25/23 16:06, Ben Boeckel wrote: >>> They affect the build, so report them via `-MF` mechanisms. >> >> Why isn't this covered by the existing code in preprocessed_module? > > It appears as though it is neutered in patch 3 where > `write_make_modules_deps` is used in `make_write` (or will use that name Why do you want to record the transitive modules? I would expect just noting the ones with imports directly in the TU would suffice (i.e check the 'outermost' arg) nathan -- Nathan Sidwell