From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by sourceware.org (Postfix) with ESMTPS id 57EEC3858D20; Sat, 21 Jan 2023 18:27:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 57EEC3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f171.google.com with SMTP id g23so7972730plq.12; Sat, 21 Jan 2023 10:27:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=dJxbHgnXYbwhNWI+DDSnuZs2xmZVvJAFAXhWX2W2RNE=; b=mumRgT92b3EbHzoESZxd3Yl55qOhDY3nokrgSxw4lrltQtGp43cSqhLTd2aMM5PJtB N2odsQW17OOXKX1wqxmptUurjxQQYqNKHIExWhLi2BCJcnGCQs6ndKsVCOw4c+RFq7Wc ROn5Wq9NwQP9C/TkdIpIr8o/W4fT/dP0LeNsbU/12m5o+/yTjK/a1W0ViVfouwE5emx7 WxMPZlXu4gZPV2DLz8QHlEXVaBL7Xw5pCOcJU1DX5U9AvoOP0zt4M7H3Ug3h4h4W2fMS bTPOoSxMkakt2zKOK84d+eC9Cy3Ncznu3jmccZ90jEcvS7KNIZdQ7vabadL4SjMwneie /6nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dJxbHgnXYbwhNWI+DDSnuZs2xmZVvJAFAXhWX2W2RNE=; b=SxrByCHxvp1O/Z5z2J0pwi7ip43c2CKWBLf6C6vYbTsoBpeRYAIEEPCPgh4yClL4yY vjpKZFvKkVLzSoM9PZn8oRVesQM8S25FrwjVcedheuH0yj7NNhP6KjEJYnLNnZ4KMSzB r5rHvCfTsna2AtoezLouAsk5nKzJYPjSiHOnSoDXtO+EdM6/nLoYUrk/o2WQLpTjJpk3 Q9HNsjR8cTWoyR9KMPNE8yCNoIvqGFSeUUpztvvEExuhycecLlRBx+9eyjBlxuYhyvrk 3Idmsf2FTdaz5YZ7gMLmYk2fSkQSuI1cARCmvZaqPvSsVazl6n2a3ZVI4u9aJY8OlPLo gdwA== X-Gm-Message-State: AFqh2kr7R7eoOagiYZpyUEWX2Tly8p3UHx4iFuo3GJanyL3Nm/bKdHvq Up+PTgXS8nocv9IW6cESq7kFoZh2SYSqeA== X-Google-Smtp-Source: AMrXdXtwRKmtjS9J5PqMKvo9NqLE8WeBhr8X5m5vAy7nBIdH/4VWbxqI0HP99tTDfAwI+QUEm/by7A== X-Received: by 2002:a17:903:41d2:b0:193:1c8f:183a with SMTP id u18-20020a17090341d200b001931c8f183amr4637666ple.5.1674325623909; Sat, 21 Jan 2023 10:27:03 -0800 (PST) Received: from [192.168.1.20] ([50.37.188.226]) by smtp.gmail.com with ESMTPSA id p9-20020a170902e74900b00194c6c63693sm5810841plf.80.2023.01.21.10.27.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Jan 2023 10:27:03 -0800 (PST) Content-Type: multipart/mixed; boundary="------------Wx1rNJVabkc6tdjnfXg0gNAS" Message-ID: <55839173-e1ca-f047-cef4-b66a911f1577@gmail.com> Date: Sat, 21 Jan 2023 10:27:02 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [patch. fortran] PR102595 ICE in var_element, at fortran/decl.c Content-Language: en-US From: Jerry D To: gfortran Cc: gcc-patches References: <954b2104-fd92-1e77-5565-7e41b0f8194f@gmail.com> In-Reply-To: <954b2104-fd92-1e77-5565-7e41b0f8194f@gmail.com> X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------Wx1rNJVabkc6tdjnfXg0gNAS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/20/23 9:16 PM, Jerry D wrote: > On 1/20/23 5:46 PM, Jerry D wrote: >> A PARAMETER value is not allowed in a DATA statement, similar to an >> EQUIVALENCE. >> >> The check for this was in gfc_assign_data_value() in data.cc which >> turns out to be too late when trying to assign a zero sized array. > > Correction, the chunk in data.cc must remain for one test case. I > spotted this after rerunning check-fortran for several variations. > Attached patch is revised to include a new test case and adjustment of an existing test case. It also adds in a return MATCH_ERROR I accidentally left of the first submit when I was cleaning some things up. Ok for Mainline? Jeyy --------------Wx1rNJVabkc6tdjnfXg0gNAS Content-Type: text/x-patch; charset=UTF-8; name="pr102595b.diff" Content-Disposition: attachment; filename="pr102595b.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2djYy9mb3J0cmFuL2RhdGEuY2MgYi9nY2MvZm9ydHJhbi9kYXRhLmNj CmluZGV4IDQ0M2QzNWRhOWNmLi5kMjllYjEyYzFiMSAxMDA2NDQKLS0tIGEvZ2NjL2ZvcnRy YW4vZGF0YS5jYworKysgYi9nY2MvZm9ydHJhbi9kYXRhLmNjCkBAIC0yNDQsMTMgKzI0NCw2 IEBAIGdmY19hc3NpZ25fZGF0YV92YWx1ZSAoZ2ZjX2V4cHIgKmx2YWx1ZSwgZ2ZjX2V4cHIg KnJ2YWx1ZSwgbXB6X3QgaW5kZXgsCiAJCSAgICAiYXJyYXktZWxlbWVudCBub3IgYSBzY2Fs YXItc3RydWN0dXJlLWNvbXBvbmVudCI7CiAKICAgc3ltYm9sID0gbHZhbHVlLT5zeW10cmVl LT5uLnN5bTsKLSAgaWYgKHN5bWJvbC0+YXR0ci5mbGF2b3IgPT0gRkxfUEFSQU1FVEVSKQot ICAgIHsKLSAgICAgIGdmY19lcnJvciAoIlBBUkFNRVRFUiAlcXMgc2hhbGwgbm90IGFwcGVh ciBpbiBhIERBVEEgc3RhdGVtZW50IGF0ICVMIiwKLQkJIHN5bWJvbC0+bmFtZSwgJmx2YWx1 ZS0+d2hlcmUpOwotICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KLQogICBpbml0ID0gc3lt Ym9sLT52YWx1ZTsKICAgbGFzdF90cyA9ICZzeW1ib2wtPnRzOwogICBsYXN0X2NvbiA9IE5V TEw7CmRpZmYgLS1naXQgYS9nY2MvZm9ydHJhbi9wcmltYXJ5LmNjIGIvZ2NjL2ZvcnRyYW4v cHJpbWFyeS5jYwppbmRleCA1NDNkOWNjMGRlNC4uMjhjZTVmZWE4NjUgMTAwNjQ0Ci0tLSBh L2djYy9mb3J0cmFuL3ByaW1hcnkuY2MKKysrIGIvZ2NjL2ZvcnRyYW4vcHJpbWFyeS5jYwpA QCAtNDA3Niw4ICs0MDc2LDE0IEBAIG1hdGNoX3ZhcmlhYmxlIChnZmNfZXhwciAqKnJlc3Vs dCwgaW50IGVxdWl2X2ZsYWcsIGludCBob3N0X2ZsYWcpCiAJICBnZmNfZXJyb3IgKCJOYW1l ZCBjb25zdGFudCBhdCAlQyBpbiBhbiBFUVVJVkFMRU5DRSIpOwogCSAgcmV0dXJuIE1BVENI X0VSUk9SOwogCX0KLSAgICAgIC8qIE90aGVyd2lzZSB0aGlzIGlzIGNoZWNrZWQgZm9yIGFu ZCBhbiBlcnJvciBnaXZlbiBpbiB0aGUKLQkgdmFyaWFibGUgZGVmaW5pdGlvbiBjb250ZXh0 IGNoZWNrcy4gICovCisgICAgICBpZiAoZ2ZjX2luX21hdGNoX2RhdGEoKSkKKwl7CisJICBn ZmNfZXJyb3IgKCJQQVJBTUVURVIgJXFzIHNoYWxsIG5vdCBhcHBlYXIgaW4gYSBEQVRBIHN0 YXRlbWVudCBhdCAlQyIsCisJCSAgICAgIHN5bS0+bmFtZSk7CisJICByZXR1cm4gTUFUQ0hf RVJST1I7CisJfQorCS8qIE90aGVyd2lzZSB0aGlzIGlzIGNoZWNrZWQgZm9yIGFuIGVycm9y IGdpdmVuIGluIHRoZQorCSAgIHZhcmlhYmxlIGRlZmluaXRpb24gY29udGV4dCBjaGVja3Mu ICAqLwogICAgICAgYnJlYWs7CiAKICAgICBjYXNlIEZMX1BST0NFRFVSRToKZGlmZiAtLWdp dCBhL2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvcGFyYW1ldGVyX2RhdGEwLmY5MCBiL2dj Yy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvcGFyYW1ldGVyX2RhdGEwLmY5MApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uNGYxZGE5ZWE0MmUKLS0tIC9kZXYvbnVs bAorKysgYi9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL3BhcmFtZXRlcl9kYXRhMC5mOTAK QEAgLTAsMCArMSw2IEBACishIHsgZGctZG8gY29tcGlsZSB9CishIFBSIGZvcnRyYW4vMTAy NTk1ICBTaW1pbGFyIHRvIDg4MDQ4IHdpdGggYSB6ZXJvIHNpemVkIGFycmF5Citwcm9ncmFt IHAKKyAgIGNvbXBsZXgsIHBhcmFtZXRlcjo6IHgoMCkgPSAyCisgICBkYXRhIHglaW0gLzMu MC8gISB7IGRnLWVycm9yICJzaGFsbCBub3QgYXBwZWFyIGluIGEgREFUQSBzdGF0ZW1lbnQi IH0KK2VuZApkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9wcjg4MDQ4 LmY5MCBiL2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvcHI4ODA0OC5mOTAKaW5kZXggMTEy OTM5MzQzMzAuLmFkODJkNDU4ODFjIDEwMDY0NAotLS0gYS9nY2MvdGVzdHN1aXRlL2dmb3J0 cmFuLmRnL3ByODgwNDguZjkwCisrKyBiL2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvcHI4 ODA0OC5mOTAKQEAgLTIsNiArMiw2IEBACiAhIFBSIGZvcnRyYW4vODgwNDgKIHByb2dyYW0g cAogICAgaW50ZWdlciwgcGFyYW1ldGVyIDo6IGEoMikgPSAxCi0gICBkYXRhIGEoMikgL2Eo MSkvICAgICAgICAgICAgICAgICAhIHsgZGctZXJyb3IgImRlZmluYWJsZSBlbnRpdHkiIH0K KyAgIGRhdGEgYSgyKSAvYSgxKS8gICEgeyBkZy1lcnJvciAic2hhbGwgbm90IGFwcGVhciBp biBhIERBVEEgc3RhdGVtZW50IiB9CiAgICBwcmludCAqLCBhCiBlbmQK --------------Wx1rNJVabkc6tdjnfXg0gNAS--