From: Thomas Koenig <tkoenig@netcologne.de>
To: sgk@troutmask.apl.washington.edu
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, Fortran] Fix PR 82372
Date: Tue, 10 Oct 2017 19:02:00 -0000 [thread overview]
Message-ID: <55921521-0562-f119-0fbc-613ab2c4fe8a@netcologne.de> (raw)
In-Reply-To: <20171010180659.GA47246@troutmask.apl.washington.edu>
Hi Steve,
>> the attached patch displays an error for characters which are
>> outside the normal Fortran character set, and includes a hex
>
> If this ^^^^^^^^^^^^^^^^^^^^^
> corresponds to this statement,
>
>>
>> +char valid_chars[] =
>> + "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"
>> + "=+*-/^%[].,\n\t\r'\"();:<>_!$&0123456789";
>
> then this is not correct.
You're correct, my statement above was misleading.
What I meant was the characters which can occur inside
normal Fortran syntax, plus a few more places, such as an
!$OMP statement.
From F2003, letters, digits,
> underscore, and special characters (see Table 3.1) are
> members of the Fortran character set. Your string includes
> \n, \t, and \r, which are not in the Fortran character set.
\t we warn about separetely. \n and \r can occur during parsing,
so we should not warn about them,
> Your string is missing \, {, }, ~, `, |, #, and @.
AFAIK, none of these characters can come up in an normal Fortran
statement except for a comment, string, format or continuation
character in fixed form.
Regards
Thomas
prev parent reply other threads:[~2017-10-10 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 17:42 Thomas Koenig
2017-10-10 18:07 ` Steve Kargl
2017-10-10 19:02 ` Thomas Koenig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55921521-0562-f119-0fbc-613ab2c4fe8a@netcologne.de \
--to=tkoenig@netcologne.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).