From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113377 invoked by alias); 10 Oct 2017 19:02:07 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 112386 invoked by uid 89); 10 Oct 2017 19:02:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=letters X-Spam-User: qpsmtpd, 2 recipients X-HELO: cc-smtpout1.netcologne.de Received: from cc-smtpout1.netcologne.de (HELO cc-smtpout1.netcologne.de) (89.1.8.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Oct 2017 19:02:05 +0000 Received: from cc-smtpin1.netcologne.de (cc-smtpin1.netcologne.de [89.1.8.201]) by cc-smtpout1.netcologne.de (Postfix) with ESMTP id DFF9813457; Tue, 10 Oct 2017 21:02:00 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by cc-smtpin1.netcologne.de (Postfix) with ESMTP id DE3A411DF8; Tue, 10 Oct 2017 21:02:00 +0200 (CEST) Received: from [78.35.132.98] (helo=cc-smtpin1.netcologne.de) by localhost with ESMTP (eXpurgate 4.1.9) (envelope-from ) id 59dd1928-029d-7f0000012729-7f000001cb2a-1 for ; Tue, 10 Oct 2017 21:02:00 +0200 Received: from [192.168.178.20] (xdsl-78-35-132-98.netcologne.de [78.35.132.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin1.netcologne.de (Postfix) with ESMTPSA; Tue, 10 Oct 2017 21:01:57 +0200 (CEST) Subject: Re: [patch, Fortran] Fix PR 82372 To: sgk@troutmask.apl.washington.edu Cc: "fortran@gcc.gnu.org" , gcc-patches References: <8f13912c-0bf1-b570-cf72-a32b1bef2e26@netcologne.de> <20171010180659.GA47246@troutmask.apl.washington.edu> From: Thomas Koenig Message-ID: <55921521-0562-f119-0fbc-613ab2c4fe8a@netcologne.de> Date: Tue, 10 Oct 2017 19:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171010180659.GA47246@troutmask.apl.washington.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00061.txt.bz2 Hi Steve, >> the attached patch displays an error for characters which are >> outside the normal Fortran character set, and includes a hex > > If this ^^^^^^^^^^^^^^^^^^^^^ > corresponds to this statement, > >> >> +char valid_chars[] = >> + "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ" >> + "=+*-/^%[].,\n\t\r'\"();:<>_!$&0123456789"; > > then this is not correct. You're correct, my statement above was misleading. What I meant was the characters which can occur inside normal Fortran syntax, plus a few more places, such as an !$OMP statement. >From F2003, letters, digits, > underscore, and special characters (see Table 3.1) are > members of the Fortran character set. Your string includes > \n, \t, and \r, which are not in the Fortran character set. \t we warn about separetely. \n and \r can occur during parsing, so we should not warn about them, > Your string is missing \, {, }, ~, `, |, #, and @. AFAIK, none of these characters can come up in an normal Fortran statement except for a comment, string, format or continuation character in fixed form. Regards Thomas