From: Mikael Morin <mikael.morin@sfr.fr>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>,
fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON
Date: Thu, 01 Oct 2015 12:16:00 -0000 [thread overview]
Message-ID: <560D240C.5070405@sfr.fr> (raw)
In-Reply-To: <20151001000740.GC73614@troutmask.apl.washington.edu>
Le 01/10/2015 02:07, Steve Kargl a écrit :
> On Wed, Sep 30, 2015 at 05:06:30PM -0700, Steve Kargl wrote:
>> Patch built and regression tested on x86_64-*-freebsd.
>> OK to commit?
>>
>> The patch prevents the dereferencing of a NULL pointer
>> by jumping out of the cleanup of a list of COMMON blocks.
>>
Hold on, I believe p should be present in the common symbol list pointed
by p->common.
And by the way, if we are in gfc_restore_last_undo_checkpoint, we have
found something bogus enough to backtrack, so hopefully an error has
already been prepared (but maybe not emitted).
I will investigate more.
Mikael
next prev parent reply other threads:[~2015-10-01 12:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 0:06 Steve Kargl
2015-10-01 0:07 ` Steve Kargl
2015-10-01 12:16 ` Mikael Morin [this message]
2015-10-01 13:29 ` Mikael Morin
2015-10-01 16:30 ` Steve Kargl
2015-10-02 9:28 ` Mikael Morin
2015-10-02 16:44 ` Steve Kargl
2015-10-03 10:13 ` Mikael Morin
2015-10-03 19:09 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560D240C.5070405@sfr.fr \
--to=mikael.morin@sfr.fr \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).