From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113634 invoked by alias); 1 Oct 2015 12:16:26 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 113610 invoked by uid 89); 1 Oct 2015 12:16:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp26.services.sfr.fr Received: from smtp26.services.sfr.fr (HELO smtp26.services.sfr.fr) (93.17.128.163) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 01 Oct 2015 12:16:23 +0000 Received: from filter.sfr.fr (localhost [86.72.15.181]) by msfrf2604.sfr.fr (SMTP Server) with ESMTP id 231E11C000C4D; Thu, 1 Oct 2015 14:16:19 +0200 (CEST) Authentication-Results: sfrmc.priv.atos.fr; dkim=none (no signature); dkim-adsp=none (no policy) header.from=mikael.morin@sfr.fr Received: from [192.168.1.86] (181.15.72.86.rev.sfr.net [86.72.15.181]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by msfrf2604.sfr.fr (SMTP Server) with ESMTP id AB7911C000837; Thu, 1 Oct 2015 14:16:13 +0200 (CEST) X-SFR-UUID: 20151001121613702.AB7911C000837@msfrf2604.sfr.fr Subject: Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON To: Steve Kargl , fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org References: <20151001000630.GB73614@troutmask.apl.washington.edu> <20151001000740.GC73614@troutmask.apl.washington.edu> From: Mikael Morin Message-ID: <560D240C.5070405@sfr.fr> Date: Thu, 01 Oct 2015 12:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151001000740.GC73614@troutmask.apl.washington.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00006.txt.bz2 Le 01/10/2015 02:07, Steve Kargl a écrit : > On Wed, Sep 30, 2015 at 05:06:30PM -0700, Steve Kargl wrote: >> Patch built and regression tested on x86_64-*-freebsd. >> OK to commit? >> >> The patch prevents the dereferencing of a NULL pointer >> by jumping out of the cleanup of a list of COMMON blocks. >> Hold on, I believe p should be present in the common symbol list pointed by p->common. And by the way, if we are in gfc_restore_last_undo_checkpoint, we have found something bogus enough to backtrack, so hopefully an error has already been prepared (but maybe not emitted). I will investigate more. Mikael