From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86026 invoked by alias); 31 Oct 2015 18:01:18 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 86005 invoked by uid 89); 31 Oct 2015 18:01:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 31 Oct 2015 18:01:16 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1ZsaSl-0006ct-Et from Cesar_Philippidis@mentor.com ; Sat, 31 Oct 2015 11:01:11 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.224.2; Sat, 31 Oct 2015 11:01:11 -0700 Subject: Re: more accurate omp in fortran To: =?UTF-8?Q?Dominique_d'Humi=c3=a8res?= References: <0A6A6FA1-6322-4151-B739-4FA79EAD07BE@lps.ens.fr> CC: jakub Jelinek , gfortran , gcc-patches From: Cesar Philippidis Message-ID: <563501E6.2030205@codesourcery.com> Date: Sat, 31 Oct 2015 18:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <0A6A6FA1-6322-4151-B739-4FA79EAD07BE@lps.ens.fr> Content-Type: multipart/mixed; boundary="------------040705020104070708000503" X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00189.txt.bz2 --------------040705020104070708000503 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Content-length: 954 On 10/30/2015 09:29 PM, Dominique d'Humières wrote: >> diff --git a/gcc/fortran/openmp.c b/gcc/fortran/openmp.c > > Revision r229609 breaks bootstrap: > > ../../work/gcc/fortran/openmp.c: In function 'void resolve_omp_clauses(gfc_code*, gfc_omp_clauses*, gfc_namespace*, bool)': > ../../work/gcc/fortran/openmp.c:2925:27: error: format '%L' expects argument of type 'locus*', but argument 3 has type 'locus' [-Werror=format=] > n->sym->name, n->where); > ^ > cc1plus: all warnings being treated as errors Sorry about that. I as I explained in PR68168, I wasn't using --enable-bootstrap when I tested this patch because I thought it was implied by default. I was able to reproduce this problem and fix it with the attached patch after I explicitly configured and built gcc with --enable-bootstrap. I've applied this patch to trunk, since it should have been included with the original patch in the first place. Cesar --------------040705020104070708000503 Content-Type: text/x-patch; name="pr68168.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="pr68168.diff" Content-length: 656 2015-10-31 Cesar Philippidis PR Bootstrap/68168 gcc/fortran/ * openmp.c (resolve_omp_clauses): Pass &n->where when calling gfc_error. diff --git a/gcc/fortran/openmp.c b/gcc/fortran/openmp.c index 3fd19b8..e59139c 100644 --- a/gcc/fortran/openmp.c +++ b/gcc/fortran/openmp.c @@ -2922,7 +2922,7 @@ resolve_omp_clauses (gfc_code *code, gfc_omp_clauses *omp_clauses, { if (!code && (!n->sym->attr.dummy || n->sym->ns != ns)) gfc_error ("Variable %qs is not a dummy argument at %L", - n->sym->name, n->where); + n->sym->name, &n->where); continue; } if (n->sym->attr.flavor == FL_PROCEDURE --------------040705020104070708000503--