From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id 507FD3858D1E; Wed, 11 Oct 2023 19:21:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 507FD3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1697052112; x=1697656912; i=anlauf@gmx.de; bh=cQ0OQqMY3y2RkYzj3kfmzO2/MhrrETX67FOvA6XGVv0=; h=X-UI-Sender-Class:Date:Subject:From:To:References:In-Reply-To; b=Ng9kFC3AL+Ei6pkpnOaZ7a3EbNR8tgr9maxlof3Sw4ddV/BqrCQ75BjYe6SfuxeWLD8CiWvqabk ICxU2KFbnfrMkoWamniKBU+pYCsmkhdf95BterJTkOEa3oQHyOhC5XHYd0XWDLl5ynecSWqaa4DJb bj0J/csRKws98YjNjgITfkmb7XhhSfWKVKEVO5VR2uoI1wwxYKFaWd/si8IRRLoe13g3INO3L/Af0 6iArrQTQbEAuKBRM3KuzxowKjChG/+dyKeT9BJOxB5HR/xjS0I32uX6l7HO9+YbKDme68j2C7dgdT GxRW9+GmpJi1GyJmBltRh82JpzSMPJGHsZJg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([79.251.14.159]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MmDEm-1rGsnA1viS-00iEq6; Wed, 11 Oct 2023 21:21:52 +0200 Message-ID: <563d4b18-eeff-453d-b7e4-3fff30df09e1@gmx.de> Date: Wed, 11 Oct 2023 21:21:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch, fortran] PR67740 - Wrong association status of allocatable character pointer in derived types From: Harald Anlauf To: Paul Richard Thomas , "fortran@gcc.gnu.org" , gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <9d99ec10-3dd9-4af5-b330-f839ac601165@gmx.de> Content-Language: en-US In-Reply-To: <9d99ec10-3dd9-4af5-b330-f839ac601165@gmx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:0dD1WYK8aszjY19ej6zT7BI8eXJBKYyRHM73kbh7b8bn39vvgGo d65p72rRGNaNe3xRKLjDfyVXEnBCBupkuv6n6dYOp5sf7ej2qdpPVFKgTjYGIxCYQUjgPEi QaMPJWPTe1oPA50Bp3WQ1HWNGYuAjBrMDpVU/tpUbVb3pwbLNyMY2z4XplxQ4uNAu5EXQnF JH7wpD6bCcuLBVm7hyHmw== UI-OutboundReport: notjunk:1;M01:P0:rrXyrL2FWiQ=;l4aDtDyr9wbCLXMJliacXMtSDVw bgR4d211RpTgHdhXVDA0h9dK/U3Crv9bWSVCCsqKt6GCXWIw+iz/MCCbI8IDkgDW6SccBnaTP yTVMZt40V5YInKgB473kqNbb77SUhzWGNPbg2jt41MVMb0qr6zhU+qEPRjrqnj3vCwHDRpfvS x7RMeumMJXmbQTBXbidtJkjsrrnVA9fVg0bKO46boygFarhjj690gcGoLsD3M1sLs3gXiE/jB nO0x8otwf0VpbuG7G3IwV4Rw5eftJf956gpq0EAR3MWS7Cs61W1btln5z7e3YG9nQyEjtAv2n bg0GVNb8nrIiWyXfsHiQ4c3An4DO/8awVZCHpfGE/Cn7tD5KytSNfgwIiak5W+Fqgt0ccKOj2 FRWlLNJJO8jPScj3k0Jrf84gUb4NaHmvXn0dHr1IXa9KljeN0o469IXuYJbQPyGFxe2cgEeHZ akB9X626bYe4bOeSHDY46vbIDu/T9HSNfGQOlAeaOHBz6W0/Q8m0DOm5bMTYvg2F2xyztFkzU j8Fq9/3R/awcIYNxK0H8YE8yc+WheWCgV6Jr6CH5E/Np42ixg7WTRDs7YXjYm4srkobGuD8PM L6zmgY8ek5dfVQtr1X4ryeV1caMIt9g0gC/87Sp3Yx5ZSjBCFfgeAKriqbtnkWQeBdSWclg01 5DF/LxyninuAwVkKbKljK8BW3lU1im4hswD32wBhCca2PV1PyP6F58BmtpubtSSR8SimKMMaw YOiOWgOpUv59ou8wQVOLfTbvnPb67M2P6NZD7/o5+cYVScuZ2NB5w/s8unPianAXJVtESf9Kb CmekpKok0x654KTog1MfD0BLwAFl9riKxiDO4zzWbRFYa8WJ2UEnVmfJQYPMlnPCLV/2QaUwT epV8vRiB88Qm3xmsbB3Tlt2evu8RQGRtUy2Qkz7/6SnQjpjTLS+ldX3Ir9NAVnF8yhzsfhjM+ guqCecUriGO+bUlMkN9byZZtRSQ= X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul, the patch is fine, but I forgot the mention that the testcase needs fixing= : Instead of ! {dg-do compile } you'll likely want ! { dg-do run } (Note the space before the dg-command.) Cheers, Harald On 10/11/23 21:06, Harald Anlauf wrote: > Hi Paul, > > On 10/11/23 10:48, Paul Richard Thomas wrote: >> Hi All, >> >> The title line of the PR should have been changed a long time since. As >> noted in comment 5, the original problem was fixed in 10.5. >> >> This patch fixes the problem described in comments 4 and 6, where the >> hidden string length component was not being set in pointer assignment = of >> character arrays. >> >> The fix regtests. OK for trunk and 13-branch? > > this is OK for both. > > I'd suggest to wait a couple of days or a week before backporting. > > Thanks for the patch! > > Harald > >> Thanks are due to Harald for bringing this to my attention. >> >> Paul >> >> Fortran: Set hidden string length for pointer components [PR67440] >> >> 2023-10-11=C2=A0 Paul Thomas=C2=A0 >> >> gcc/fortran >> PR fortran/pr67740 >> * trans-expr.cc (gfc_trans_pointer_assignment): Set the hidden >> string length component for pointer assignment to character >> pointer components. >> >> gcc/testsuite/ >> PR fortran/87477 >> * gfortran.dg/pr67740.f90: New test >> > >