From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80321 invoked by alias); 10 Dec 2015 22:05:30 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 80298 invoked by uid 89); 10 Dec 2015 22:05:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wm0-f52.google.com Received: from mail-wm0-f52.google.com (HELO mail-wm0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 10 Dec 2015 22:05:28 +0000 Received: by wmec201 with SMTP id c201so44288487wme.1; Thu, 10 Dec 2015 14:05:25 -0800 (PST) X-Received: by 10.194.173.5 with SMTP id bg5mr15558440wjc.142.1449785125821; Thu, 10 Dec 2015 14:05:25 -0800 (PST) Received: from [192.168.0.3] ([94.15.201.66]) by smtp.googlemail.com with ESMTPSA id vu4sm14304985wjc.2.2015.12.10.14.05.23 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 10 Dec 2015 14:05:24 -0800 (PST) Subject: Re: [Patch, Fortran] PR68815 - replace '%s' quotes by %< ... %> To: Tobias Burnus , gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org, Joseph Myers , Jakub Jelinek References: <20151209155337.GA6991@physik.fu-berlin.de> From: =?UTF-8?B?TWFudWVsIEzDs3Blei1JYsOhw7Fleg==?= Message-ID: <5669F722.6000902@gmail.com> Date: Thu, 10 Dec 2015 22:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151209155337.GA6991@physik.fu-berlin.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00075.txt.bz2 On 12/09/2015 03:53 PM, Tobias Burnus wrote: > In principle, %<%c%> and %<%d%> should be convertable to %qc and > %qd (as the code is more readable), but the current function > annotation prevent this, telling that the q flag is not valid for > %c and %d. As %< is fine, I didn't dig into it. You need to edit the gcc_gfc_* variables in c-family/c-format.c. The correct way to do that does not seem to be documented anywhere. I only got the current support working after painful trial and error. Joseph, Jakub, could you advise the Fortran devs on how to edit c-format.c to handle %qc and %qd as the C/C++ FEs do? Thanks, Manuel