* [PATCH] Change AArch64 specific FMAX/FMIN tests into generic MAX_EXPR/MIN_EXPR tests
@ 2018-08-22 13:16 Szabolcs Nagy
2018-08-22 14:57 ` Janne Blomqvist
0 siblings, 1 reply; 3+ messages in thread
From: Szabolcs Nagy @ 2018-08-22 13:16 UTC (permalink / raw)
To: GCC Patches, Fortran List; +Cc: nd, Janne Blomqvist
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
gfortran now always uses MAX_EXPR/MIN_EXPR for MAX/MIN intrinsics, so the
AArch64 specific FMAX/FMIN tests are no longer valid.
2018-08-22 Szabolcs Nagy <szabolcs.nagy@arm.com>
* gfortran.dg/max_fmax_aarch64.f90: Rename to...
* gfortran.dg/max_expr.f90: ...this.
* gfortran.dg/min_fmin_aarch64.f90: Rename to...
* gfortran.dg/min_expr.f90: ...this.
[-- Attachment #2: max_expr.diff --]
[-- Type: text/x-patch, Size: 1534 bytes --]
diff --git a/gcc/testsuite/gfortran.dg/max_fmax_aarch64.f90 b/gcc/testsuite/gfortran.dg/max_expr.f90
similarity index 74%
rename from gcc/testsuite/gfortran.dg/max_fmax_aarch64.f90
rename to gcc/testsuite/gfortran.dg/max_expr.f90
index b818241a1f9..c00ad62f744 100644
--- a/gcc/testsuite/gfortran.dg/max_fmax_aarch64.f90
+++ b/gcc/testsuite/gfortran.dg/max_expr.f90
@@ -1,4 +1,4 @@
-! { dg-do compile { target aarch64*-*-* } }
+! { dg-do compile }
! { dg-options "-O2 -fdump-tree-optimized" }
subroutine foo (a, b, c, d, e, f, g, h)
@@ -12,4 +12,4 @@ subroutine foof (a, b, c, d, e, f, g, h)
end subroutine
-! { dg-final { scan-tree-dump-times "\.FMAX " 14 "optimized" } }
+! { dg-final { scan-tree-dump-times "MAX_EXPR " 14 "optimized" } }
diff --git a/gcc/testsuite/gfortran.dg/min_fmin_aarch64.f90 b/gcc/testsuite/gfortran.dg/min_expr.f90
similarity index 74%
rename from gcc/testsuite/gfortran.dg/min_fmin_aarch64.f90
rename to gcc/testsuite/gfortran.dg/min_expr.f90
index 009869b497d..5f32d5073c9 100644
--- a/gcc/testsuite/gfortran.dg/min_fmin_aarch64.f90
+++ b/gcc/testsuite/gfortran.dg/min_expr.f90
@@ -1,4 +1,4 @@
-! { dg-do compile { target aarch64*-*-* } }
+! { dg-do compile }
! { dg-options "-O2 -fdump-tree-optimized" }
subroutine foo (a, b, c, d, e, f, g, h)
@@ -12,4 +12,4 @@ subroutine foof (a, b, c, d, e, f, g, h)
a = min (a, b, c, d, e, f, g, h)
end subroutine
-! { dg-final { scan-tree-dump-times "\.FMIN " 14 "optimized" } }
+! { dg-final { scan-tree-dump-times "MIN_EXPR " 14 "optimized" } }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Change AArch64 specific FMAX/FMIN tests into generic MAX_EXPR/MIN_EXPR tests
2018-08-22 13:16 [PATCH] Change AArch64 specific FMAX/FMIN tests into generic MAX_EXPR/MIN_EXPR tests Szabolcs Nagy
@ 2018-08-22 14:57 ` Janne Blomqvist
2018-08-22 15:12 ` Kyrill Tkachov
0 siblings, 1 reply; 3+ messages in thread
From: Janne Blomqvist @ 2018-08-22 14:57 UTC (permalink / raw)
To: Szabolcs Nagy; +Cc: GCC Patches, Fortran List, nd
On Wed, Aug 22, 2018 at 4:16 PM, Szabolcs Nagy <szabolcs.nagy@arm.com>
wrote:
> gfortran now always uses MAX_EXPR/MIN_EXPR for MAX/MIN intrinsics, so the
> AArch64 specific FMAX/FMIN tests are no longer valid.
>
> 2018-08-22 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * gfortran.dg/max_fmax_aarch64.f90: Rename to...
> * gfortran.dg/max_expr.f90: ...this.
> * gfortran.dg/min_fmin_aarch64.f90: Rename to...
> * gfortran.dg/min_expr.f90: ...this.
>
Ok, thanks!
--
Janne Blomqvist
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Change AArch64 specific FMAX/FMIN tests into generic MAX_EXPR/MIN_EXPR tests
2018-08-22 14:57 ` Janne Blomqvist
@ 2018-08-22 15:12 ` Kyrill Tkachov
0 siblings, 0 replies; 3+ messages in thread
From: Kyrill Tkachov @ 2018-08-22 15:12 UTC (permalink / raw)
To: Janne Blomqvist, Szabolcs Nagy; +Cc: GCC Patches, Fortran List, nd
Hi all,
On 22/08/18 15:57, Janne Blomqvist wrote:
> On Wed, Aug 22, 2018 at 4:16 PM, Szabolcs Nagy <szabolcs.nagy@arm.com>
> wrote:
>
> > gfortran now always uses MAX_EXPR/MIN_EXPR for MAX/MIN intrinsics, so the
> > AArch64 specific FMAX/FMIN tests are no longer valid.
> >
> > 2018-08-22 Szabolcs Nagy <szabolcs.nagy@arm.com>
> >
> > * gfortran.dg/max_fmax_aarch64.f90: Rename to...
> > * gfortran.dg/max_expr.f90: ...this.
> > * gfortran.dg/min_fmin_aarch64.f90: Rename to...
> > * gfortran.dg/min_expr.f90: ...this.
> >
>
> Ok, thanks!
>
I've committed this on behalf of Szabolcs as r263778.
Thanks,
Kyrill
> --
> Janne Blomqvist
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-22 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-22 13:16 [PATCH] Change AArch64 specific FMAX/FMIN tests into generic MAX_EXPR/MIN_EXPR tests Szabolcs Nagy
2018-08-22 14:57 ` Janne Blomqvist
2018-08-22 15:12 ` Kyrill Tkachov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).