From: Mikael Morin <morin-mikael@orange.fr>
To: Harald Anlauf <anlauf@gmx.de>, fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Proxy ping [PATCH] Fortran: Add missing TKR initialization to class variables [PR100097, PR100098]
Date: Fri, 21 Oct 2022 13:13:00 +0200 [thread overview]
Message-ID: <5a5b09f2-cfff-63dd-8ccb-6db9b42287c9@orange.fr> (raw)
In-Reply-To: <1d2bbc40-fe52-79d5-c2db-39d27eca212c@gmx.de>
Le 18/10/2022 à 22:48, Harald Anlauf via Fortran a écrit :
> I intended to add the updated patch but forgot, so here it is...
>
> Am 18.10.22 um 22:41 schrieb Harald Anlauf via Fortran:
>> Dear all,
>>
>> Jose posted a patch here that was never reviewed:
>>
>> https://gcc.gnu.org/pipermail/fortran/2021-April/055933.html
>>
>> I could not find any issues with his patch, it works as advertised
>> and fixes the reported problem.
>>
>> As his testcases did not reliably fail without the patch but rather
>> randomly due to the uninitialized descriptor, I added a check of
>> the tree-dumps to verify that the TKR initializer is generated.
>>
>> Does anybody else have any comments?
>>
>> Regtested on x86_64-pc-linux-gnu. OK for mainline?
>>
Looks good but please check the initialization of rank instead of
elem_len in the dump patterns (elem_len actually doesn't matter).
OK with that change.
Thanks.
next prev parent reply other threads:[~2022-10-21 11:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 20:41 Harald Anlauf
2022-10-18 20:48 ` Harald Anlauf
2022-10-18 20:48 ` Harald Anlauf
2022-10-21 11:13 ` Mikael Morin [this message]
2022-10-21 18:24 ` Harald Anlauf
2022-10-21 18:24 ` Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a5b09f2-cfff-63dd-8ccb-6db9b42287c9@orange.fr \
--to=morin-mikael@orange.fr \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).