public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: dhumieres.dominique@free.fr
To: tk@tkoenig.net
Cc: fortran@gcc.gnu.org
Subject: Testsuite integration for devel/coarray_native
Date: Sun, 06 Dec 2020 18:37:18 +0100	[thread overview]
Message-ID: <5eaa24071eda33fe3512c28610cd71f5@free.fr> (raw)

Hi Thomas,

> I'm currently trying to put together a testsuite for the shared coarray
> branch.  What I have so far is a directory
> gcc/testsuite/gfortran.dg/caf-shared
> which contains the attached dejagnu file plus the test cases

I don't see the point to introduce a new directory.
IMO all the tests for coarray should pass for shared coarray
and a simple test would be to add

     foreach flags $option_list {
	verbose "Testing $nshort (libcaf_single), $flags" 1
         set gfortran_aux_module_flags "-fcoarray=shared $flags 
-lcaf_shared"
	dg-test $test "-fcoarray=shared $flags -lcaf_shared $maybe_atomic_lib" 
""
	cleanup-modules ""
     }

at the end of gfortran.dg/coarray/caf.exp.
This will cover the check of more than 60 programs.

In addition greping for "fcoarray=" in gfortran.dg shows 200 programs
which should be moved to gfortran.dg/coarray/.

> but I am not sure if this is the right way to go about this
> (would this work in the absence of an installed caf_shared library,
> would this cause lots of failures on systems without pthreads, ...?)

Presently if shared coarray is not supported it is impossible to 
bootstrap.
IMO for the moment it is putting "la charrue avant le boeufs" (the plow
before the oxen) to discuss what to do for the tests before having
a solution to bootstrap without -lcaf_shared.

I don't thing the shared coarray tests should go under libgomp.

Cheers,

Dominique

             reply	other threads:[~2020-12-06 17:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-06 17:37 dhumieres.dominique [this message]
2020-12-06 21:52 ` Thomas König
  -- strict thread matches above, loose matches on Subject: below --
2020-12-05 15:13 Thomas König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5eaa24071eda33fe3512c28610cd71f5@free.fr \
    --to=dhumieres.dominique@free.fr \
    --cc=fortran@gcc.gnu.org \
    --cc=tk@tkoenig.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).