public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jerry DeLisle <jvdelisle@charter.net>
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>,
	"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, fortran] PR84546 - [7/8 Regression] Bad sourced allocation of CLASS(*) with source with CLASS(*) component
Date: Sun, 11 Mar 2018 19:35:00 -0000	[thread overview]
Message-ID: <62e42646-92d7-66c8-c112-eb4ceac9aaca@charter.net> (raw)
In-Reply-To: <CAGkQGi+-Ch7H1p6D-iA+ZAx7N6BxMfJHYkvE0GAPmao-x9-0Gw@mail.gmail.com>

On 03/11/2018 12:23 PM, Paul Richard Thomas wrote:
> This regression came about because the vtable deep copy for derived
> types with unlimited polymorphic components was not making use of the
> _len parameter to compute the memory to be allocated and the offsets
> to array elements.
> 
> The ChangeLogs are reasonably self explanatory.
> 
> Bootstraps and regtests on FC27/x86_64 - OK for trunk and 7-branch?

Yes, OK and thanks for the work.

Jerry
> 
> Paul
> 
> 2018-03-11  Paul Thomas  <pault@gcc.gnu.org>
> 
>      PR fortran/84546
>      * trans-array.c (structure_alloc_comps): Make sure that the
>      vptr is copied and that the unlimited polymorphic _len is used
>      to compute the size to be allocated.
>      * trans-expr.c (gfc_get_class_array_ref): If unlimited, use the
>      unlimited polymorphic _len for the offset to the element.
>      (gfc_copy_class_to_class): Set the new 'unlimited' argument.
>      * trans.h : Add the boolean 'unlimited' to the prototype.
> 
> 2018-03-11  Paul Thomas  <pault@gcc.gnu.org>
> 
>      PR fortran/84546
>      * gfortran.dg/unlimited_polymorphic_29.f90 : New test.
> 

      reply	other threads:[~2018-03-11 19:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-11 19:24 Paul Richard Thomas
2018-03-11 19:35 ` Jerry DeLisle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62e42646-92d7-66c8-c112-eb4ceac9aaca@charter.net \
    --to=jvdelisle@charter.net \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=paul.richard.thomas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).