public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: Mikael Morin <morin-mikael@orange.fr>,
	fortran <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR fortran/103418 - random_number() does not accept pointer, intent(in) array argument
Date: Tue, 7 Dec 2021 21:46:04 +0100	[thread overview]
Message-ID: <65b5dd1c-ed9f-374f-8c42-00e981d9a491@gmx.de> (raw)
In-Reply-To: <cac5a359-4197-a78a-3c4e-4be26aac9a76@orange.fr>

Hi Mikael,

Am 07.12.21 um 21:17 schrieb Mikael Morin:
> Hello,
>
> On 05/12/2021 22:55, Harald Anlauf via Fortran wrote:
>> Dear all,
>>
>> the check of dummy arguments with pointer attribute and INTENT(IN)
>> was broken in the case the argument was passed to an intrinsic.
>> We therefore rejected valid code as e.g. given in the PR.
>>
>> The patch relaxes the excessive check.  This requires the adjustment
>> of one of the tests for MOVE_ALLOC.
> The existing code looks dubious to me (or at least difficult to
> understand), and your patch doesn’t make that any better.
> I would rather try to remove the whole block, and fix the fallout on
> move_alloc by adding calls to gfc_check_vardef_context in
> gfc_check_move_alloc.
> Can you try that instead?

I hadn't thought that far but will think about a possibly better
solution.

Thanks,
Harald



  reply	other threads:[~2021-12-07 20:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-05 21:55 Harald Anlauf
2021-12-07 20:17 ` Mikael Morin
2021-12-07 20:46   ` Harald Anlauf [this message]
2021-12-08  9:32     ` Mikael Morin
2021-12-09 22:05       ` [PATCH, v2] " Harald Anlauf
2021-12-09 22:05         ` Harald Anlauf
2021-12-10 12:28         ` Mikael Morin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65b5dd1c-ed9f-374f-8c42-00e981d9a491@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=morin-mikael@orange.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).