From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13302 invoked by alias); 6 Apr 2017 14:26:54 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 12874 invoked by uid 89); 6 Apr 2017 14:26:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-22.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_RED autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Apr 2017 14:26:50 +0000 Received: from svr-orw-mbx-01.mgc.mentorg.com ([147.34.90.201]) by relay1.mentorg.com with esmtp id 1cw8N7-0004Wt-FT from Cesar_Philippidis@mentor.com ; Thu, 06 Apr 2017 07:26:49 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 6 Apr 2017 07:26:47 -0700 Subject: Re: [gomp4] add support for fortran allocate support with declare create To: Thomas Schwinge References: <86f51209-c59d-a4cf-297d-9a072823aa61@codesourcery.com> <87bms9hpof.fsf@euler.schwinge.homeip.net> CC: "gcc-patches@gcc.gnu.org" , Fortran List , Chung-Lin Tang From: Cesar Philippidis Message-ID: <6680d010-6b7c-6905-650d-7e450a218363@codesourcery.com> Date: Thu, 06 Apr 2017 14:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87bms9hpof.fsf@euler.schwinge.homeip.net> Content-Type: multipart/mixed; boundary="------------7E733EE93D5F5CF5715786B1" X-ClientProxiedBy: svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) To svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00015.txt.bz2 --------------7E733EE93D5F5CF5715786B1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-length: 1259 On 04/06/2017 02:05 AM, Thomas Schwinge wrote: >> --- /dev/null >> +++ b/gcc/testsuite/gfortran.dg/goacc/declare-allocatable-1.f90 >> @@ -0,0 +1,25 @@ >> +! Verify that OpenACC declared allocatable arrays have implicit >> +! OpenACC enter and exit pragmas at the time of allocation and >> +! deallocation. >> + >> +! { dg-additional-options "-fdump-tree-original" } >> +[...] >> +! { dg-final { scan-tree-dump-times "pragma acc enter data map.declare_allocate" 1 "gimple" } } >> +! { dg-final { scan-tree-dump-times "pragma acc exit data map.declare_deallocate" 1 "gimple" } } > > UNRESOLVED: gfortran.dg/goacc/declare-allocatable-1.f90 -O scan-tree-dump-times gimple "pragma acc enter data map.declare_allocate" 1 > UNRESOLVED: gfortran.dg/goacc/declare-allocatable-1.f90 -O scan-tree-dump-times gimple "pragma acc exit data map.declare_deallocate" 1 > PASS: gfortran.dg/goacc/declare-allocatable-1.f90 -O (test for excess errors) > > "original" vs. "gimple" -- which one should it be? I'm bad at noticing new unresolved test cases. It could be either, but I changed it to original to ensure that the fortran FE inserts those acc enter/exit data directives appropriately. This patch has been committed to gomp-4_0-branch. Cesar --------------7E733EE93D5F5CF5715786B1 Content-Type: text/x-patch; name="gomp4-declare-test.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="gomp4-declare-test.diff" Content-length: 896 2017-04-06 Cesar Philippidis gcc/testsuite/ * gfortran.dg/goacc/declare-allocatable-1.f90: Correct test. diff --git a/gcc/testsuite/gfortran.dg/goacc/declare-allocatable-1.f90 b/gcc/testsuite/gfortran.dg/goacc/declare-allocatable-1.f90 index 9195055..b6bb6b3 100644 --- a/gcc/testsuite/gfortran.dg/goacc/declare-allocatable-1.f90 +++ b/gcc/testsuite/gfortran.dg/goacc/declare-allocatable-1.f90 @@ -21,5 +21,5 @@ program allocate deallocate (a) end program allocate -! { dg-final { scan-tree-dump-times "pragma acc enter data map.declare_allocate" 1 "gimple" } } -! { dg-final { scan-tree-dump-times "pragma acc exit data map.declare_deallocate" 1 "gimple" } } +! { dg-final { scan-tree-dump-times "pragma acc enter data map.declare_allocate" 1 "original" } } +! { dg-final { scan-tree-dump-times "pragma acc exit data map.declare_deallocate" 1 "original" } } --------------7E733EE93D5F5CF5715786B1--