From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id 60AF93857720; Fri, 7 Apr 2023 09:41:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 60AF93857720 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1680860513; i=anlauf@gmx.de; bh=wGuctuRoN4jdiR0LFhgx/mvdFb0c72k5127rbvpHW/I=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=SY//pNgCTZle2nddwRTX1hxKyGQq5Uj2lQUE9qa5+15PZEDFk9MtR0TU8T4JTggDm dXtvWhn59ejTlHNQfaL+6vuy0jOIkpsPfvB38pMgEvHCaaaTg4El2PV5iJ1xrVqQA6 celTlyMmt9sdVF3TO/p7WRC3rQyX2pPhwyba/eLicNhuFPfDwkz+XfLDB2fr3o+3b+ c06AxWhqKkPsz7XsgnKDBwMjgDD13kJJXUVaOideStW0DStBnEQ/6os2npCzk8fu/u QgKXVnfX/qLTe2l2Sdm8OSzQB9L5QuQeiwlaYGQqGwhu/Thu2VPeRnhVzM3LRn+njm r5IrgqM8W0jLw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.89.174]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N7zBb-1qW4I61BNz-0155EJ; Fri, 07 Apr 2023 11:41:53 +0200 Message-ID: <67044cbd-2fa5-8abf-e1d2-42fb150d0124@gmx.de> Date: Fri, 7 Apr 2023 11:41:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: Ping! [Patch, fortran] PR87477 - [meta-bug] [F03] issues concerning the ASSOCIATE statement Content-Language: en-US To: Paul Richard Thomas , "fortran@gcc.gnu.org" , gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:v/2W253lmNSZ6xjD3qHuuar+rwQ01N8K6gJYGJI1VPGn57RXITm 1mQYcIhgHGXiYMsi31zAb0a2aDLoXkXBIoQUxKQkCAHTF8zqeZFt9+MUM0MiZMVntBd8yra oXsFfd8N3Zwo3IKfbFpPP2OR+y1xTE6fwS/4qd9knqtT55NHL3HSoHzY9pus+7YQjE1PKaS OMv6RrMeUNpgR4hltJ//A== UI-OutboundReport: notjunk:1;M01:P0:ild/TB81e9Y=;jFE/UF0NlnbzBJ0lfl8hfN7uuVZ V0LTZhSoDhS/gNHFljcylx62Jh3d5jnz7xeU+rT93cWmBlSlPL56sTx48mOdMVyG5gV4E8s9h uO+EiD2wWfu6CQbCexwyfNIJ+7crKFmh5m3XLWX2M4GwIQqv8lW3Snxmo1527RLx1IwAHuQeC tQrI+OhaSrFyof6nk0orLlzniNEM2tZI+2FFtbbY1dq0Iqu5WEqfL1Lm2b+nvH042VYXMOuVd Pn1WdoIsWQV8XV4hEjbSCphy/ADEQBxnl5gOR67f2DR/wN/ZWEoAPD772erV3ObUNnanxlX0V AleCEAxk2E1GWvbRnoHu6LOLEpurofcRFnmlxFTqJWi1ukK8F87SeAQrbwbERX6SDGvLdcNs9 F+a1bFEio0HxIflf16EOrLk3FqPzoGUpLwf1OVOA5qGYG8GdtBsbDc+PB+Fye8XfTNqNl8dwA VwlUSClQoYLqmwnmfW1LEtVZ8oumflhQyibZuowTn2cPbTrEWGb6AzC8rTlzJa1BO3+s8R7uQ x5sC/5pnCNkzcsBLRqD7xECjj2XkCwmWiYLiA4kQAN4b9ecvNCOj5NyD0VzGjLSHWg89GBHgS /PZdx3uIQBmXKeqzXQu5jAJQWYynvpAAAW98DH5wGysQtE71AuvRdNREd4NKNpFx79ytLZc14 JznOAMaBIgVIryLvyjOGMA9l88e1/U1GwkI/OlG6xnAvqOtpqwEQsIYY2nXCV2ElmFO9XlayC mAGRJI2r5NZ4pQ63z9RIbBUjZ3A7Rd99yBL7kI76nsYmZl184+5cSS4XBqkZapBFA2fEH0Lc+ 2zpY0ge+jKoMTITaEZ6bxdzO8PLXoKpBzGBsiHDWS3w2Ict3g/7hVGeeEhvRDfEHPtRsfqj8J kse6RMX9NIvx3ftBw31V5lcdn2CDZ5xflt9tJf7m7Mt30Ygxw42ibMtvr8j85/EHcghwTS7Tt 8LuCmMUNLJAI5wHlHnw6gV4gUlU= X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul, I don't see the new testcases. Is this an issue on my side, or did you forget to attach them? Thanks, Harald On 4/7/23 09:07, Paul Richard Thomas via Gcc-patches wrote: > Dear All, > > Please find attached a slightly updated version of the patch with a > consolidated testcase. The three additional testcases are nothing to do > with associate and test fixes of character related bugs. > > OK for mainline? > > Cheers > > Paul > Fortran: Fix some of the bugs in associate [PR87477] > > 2023-04-07 Paul Thomas > > gcc/fortran > PR fortran/87477 > * resolve.cc (resolve_assoc_var): Handle parentheses around the > target expression. > (resolve_block_construct): Remove unnecessary static decls. > * trans-array.cc (gfc_conv_expr_descriptor): Guard string len > expression in condition. Improve handling of string length and > span, especially for substrings of the descriptor. > (duplicate_allocatable): Make element type more explicit with > 'eltype'. > * trans_decl.cc (gfc_get_symbol_decl): Emit a fatal error with > appropriate message instead of ICE if symbol type is unknown. > * trans-expr.cc (gfc_get_expr_charlen): Retain last charlen in > 'previous' and use if end expression in substring reference is > null. > (gfc_conv_string_length): Use gfc_conv_expr_descriptor if > 'expr_flat' is an array. > (gfc_trans_alloc_subarray_assign): If this is a deferred string > length component, store the string length in the hidden comp. > Update the typespec length accordingly. Generate a new type > spec for the call to gfc_duplicate-allocatable in this case. > * trans-io.cc (gfc_trans_transfer): Scalarize transfer of > deferred character array components. > > > gcc/testsuite/ > PR fortran/87477 > * gfortran.dg/finalize_47.f90 : Enable substring test. > * gfortran.dg/finalize_51.f90 : Update an error message. > > PR fortran/85686 > PR fortran/88247 > PR fortran/91941 > PR fortran/92779 > PR fortran/93339 > PR fortran/93813 > PR fortran/100948 > PR fortran/102106 > * gfortran.dg/associate_60.f90 : New test > > PR fortran/98408 > * gfortran.dg/pr98408.f90 : New test > > PR fortran/105205 > * gfortran.dg/pr105205.f90 : New test > > PR fortran/106918 > * gfortran.dg/pr106918.f90 : New test From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id D14B83858D28 for ; Fri, 7 Apr 2023 09:45:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D14B83858D28 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1pkieU-0004Kq-Bc for fortran@gcc.gnu.org; Fri, 07 Apr 2023 11:45:02 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: fortran@gcc.gnu.org From: Harald Anlauf Subject: Re: Ping! [Patch, fortran] PR87477 - [meta-bug] [F03] issues concerning the ASSOCIATE statement Date: Fri, 7 Apr 2023 11:41:52 +0200 Message-ID: <67044cbd-2fa5-8abf-e1d2-42fb150d0124@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US In-Reply-To: Cc: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20230407094152.hyNowuya0LrlXRE-5KJ3OYCj9rbfpHJMkge9KKWpXTA@z> Hi Paul, I don't see the new testcases. Is this an issue on my side, or did you forget to attach them? Thanks, Harald On 4/7/23 09:07, Paul Richard Thomas via Gcc-patches wrote: > Dear All, > > Please find attached a slightly updated version of the patch with a > consolidated testcase. The three additional testcases are nothing to do > with associate and test fixes of character related bugs. > > OK for mainline? > > Cheers > > Paul > Fortran: Fix some of the bugs in associate [PR87477] > > 2023-04-07 Paul Thomas > > gcc/fortran > PR fortran/87477 > * resolve.cc (resolve_assoc_var): Handle parentheses around the > target expression. > (resolve_block_construct): Remove unnecessary static decls. > * trans-array.cc (gfc_conv_expr_descriptor): Guard string len > expression in condition. Improve handling of string length and > span, especially for substrings of the descriptor. > (duplicate_allocatable): Make element type more explicit with > 'eltype'. > * trans_decl.cc (gfc_get_symbol_decl): Emit a fatal error with > appropriate message instead of ICE if symbol type is unknown. > * trans-expr.cc (gfc_get_expr_charlen): Retain last charlen in > 'previous' and use if end expression in substring reference is > null. > (gfc_conv_string_length): Use gfc_conv_expr_descriptor if > 'expr_flat' is an array. > (gfc_trans_alloc_subarray_assign): If this is a deferred string > length component, store the string length in the hidden comp. > Update the typespec length accordingly. Generate a new type > spec for the call to gfc_duplicate-allocatable in this case. > * trans-io.cc (gfc_trans_transfer): Scalarize transfer of > deferred character array components. > > > gcc/testsuite/ > PR fortran/87477 > * gfortran.dg/finalize_47.f90 : Enable substring test. > * gfortran.dg/finalize_51.f90 : Update an error message. > > PR fortran/85686 > PR fortran/88247 > PR fortran/91941 > PR fortran/92779 > PR fortran/93339 > PR fortran/93813 > PR fortran/100948 > PR fortran/102106 > * gfortran.dg/associate_60.f90 : New test > > PR fortran/98408 > * gfortran.dg/pr98408.f90 : New test > > PR fortran/105205 > * gfortran.dg/pr105205.f90 : New test > > PR fortran/106918 > * gfortran.dg/pr106918.f90 : New test