public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jerry D <jvdelisle2@gmail.com>
To: gfortran <fortran@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: [patch, libgfortran] PR107031 - endfile truncates file at wrong position
Date: Mon, 25 Mar 2024 20:18:57 -0700	[thread overview]
Message-ID: <67280203-8877-4be7-b988-a87fb9ff6967@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

Hi all,

There has been a bit of discussio on which way to go on this.

I took a look today and this trivial patch gives the behavior concluded 
on Fortran Discourse. See the bugzilla for all the relevant information.

Regresion tested on x86-64.

I will do the appropriate changelog.

OK for trunk?

Attached is a new test case and the patch here:

diff --git a/libgfortran/io/file_pos.c b/libgfortran/io/file_pos.c
index 2bc05b293f8..d169961f997 100644
--- a/libgfortran/io/file_pos.c
+++ b/libgfortran/io/file_pos.c
@@ -352,7 +352,6 @@ st_endfile (st_parameter_filepos *fpp)
           dtp.common = fpp->common;
           memset (&dtp.u.p, 0, sizeof (dtp.u.p));
           dtp.u.p.current_unit = u;
-         next_record (&dtp, 1);
         }

        unit_truncate (u, stell (u->s), &fpp->common);

[-- Attachment #2: endfile_5.f90 --]
[-- Type: text/x-fortran, Size: 650 bytes --]

! { dg-do run }
! PR107031 Check that endfile truncates at end of record 5.
program test_truncate
    integer :: num_rec, tmp, i, nr, j
    open(10, file="in.dat", action='readwrite')

    do i=1,10
      write(10, *) i
    end do

    rewind (10)

    num_rec = 5
    i = 1
    ioerr = 0
    do while (i <= num_rec .and. ioerr == 0)
        read(10, *, iostat=ioerr) tmp
        i = i + 1
    enddo
    endfile(10)
    rewind (10)
    i = 0
    ioerr = 0
    do while (i <= num_rec + 1 .and. ioerr == 0)
      read(10, *, iostat=ioerr) j
      i = i + 1
    end do
    close(10, status='delete')
    if (i - 1 /= 5) stop 1
end program test_truncate

             reply	other threads:[~2024-03-26  3:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26  3:18 Jerry D [this message]
2024-03-26 17:43 ` Harald Anlauf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67280203-8877-4be7-b988-a87fb9ff6967@gmail.com \
    --to=jvdelisle2@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).