From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 0ADCB3858D37; Wed, 2 Feb 2022 20:20:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0ADCB3858D37 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.29] ([79.251.11.5]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MEFvj-1n7tLD0Avl-00AEj7; Wed, 02 Feb 2022 21:20:34 +0100 Message-ID: <67713536-50cf-575e-9fdb-20d83a095d0b@gmx.de> Date: Wed, 2 Feb 2022 21:20:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] fortran: Unshare associate var charlen [PR104228] Content-Language: en-US To: Mikael Morin , gfortran , gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <204cec48-ce99-500a-7951-939ee51d31d6@orange.fr> From: Harald Anlauf In-Reply-To: <204cec48-ce99-500a-7951-939ee51d31d6@orange.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:T8eFeq6LTpYNTTMD2c9c5sw/19Ci+N3n2nposrpwDiXkMeCeogT Bl4djBFYj9ETeCPE2KcHYVB0hCfiyroxc951Yt0IM2Mefi+Se1sU4rZK6B8PM6uD2kESqtu JZOdT0YESkwUhvNY6NHb9P9kOd6vMlCZKlzwx5HwK6ot9rSk4+SHBNQvjlUAT3m6fzS0F9n AU5PzI2TM6qN7GnllOkPg== X-UI-Out-Filterresults: notjunk:1;V03:K0:qi+MfHJSdEE=:v081ct2zq3cBKte73bcsDc 6+t/prNPMWqyq5iXkDb/ZyV8E5ytcnPp3SmHF2tq6CzNYRWKBtl8tWShR3hOxzas4ycsOGa7Z 7PqPIgJE5tIh0YgRa6VrEUbCtmqRurh8Hnh2n1G1hdUJOfJda8Kl6QmWhZW59CRBB9Oqxbl/6 7qzfogdjrx+h81yiFJqZxVM6KCO39SJ0np+eezCY0OeSPI67R6heHhEKFNu0zWpRGfrgQCHr8 6Qoqsokx95aDJgl1IikX9caWVo4jlFh62uY54ry5LYaLGZEyp06C7WMsOYam7AFS9TGhmpoHu m+Y2wMP8Gw5/SNgV9hKUjdUN2N4p2weVT1F2yDGfCqtpW6fJ7HzqKRQ29kOJ9PUAlEfU5KOwJ 8+OnL3YP9tDLZFnouHVfS0ZeIdRvK7ThZaQ9/ToKA1xPhg8Hy/ilzSEAAktyJ87jxe3nIssyP yKfDlvanncKKpCzoIqBPUGDwaYJnh/MNOBd1TX14psU30AyMSJ8Jf3u5WWhZcTeEBGVVbR6J+ 4ucF2wxi7Sxi5gxtl0SjC9u7CcxlIXvDrVmTh3mFBONFUbz5Y52f4yHnZkPjICUO4QvbWjMpA OjBXrHmsAX/4B0y3pwbg4lRNAysMZTuNSRlq/ZUZJrFzE5sVyvv38VkAVBm3SWtAQ7j8R2sta FXLBMrUISyL9FQ3J9wglyoTirjczq7zw7gA1mDtQENw2QhA5pJ5tMLddr1gSys0ET9xD+jLEr Z46njPVUWjMpce9xM1LFfavybIF3PtibE65nSqo+mGj5zOAYkC/O1bPlUw9IrhvZMmpIbRxPP HVpgsEhIq8pCWxgOJ76Z46pM48qZXhBz7gM5dRrM+KRXcIaLizgdtor490e3sAxd+QpFqSWTV PNnK1lHIwGtvJGEGqKdGi+MwhT/WvHL4rPQKYrBjXF1T+kqjSdQqdjJOWiBxdhcljUzBcA/uc ZPBLUgZCWCr1jFaaDtRKOt2Qhu8MKfpBH0DWpuRdfHKr088cDCmO17xJ/oqMt1F9BFOtbkN7U WBj6xSc47kNCUzobn+nCRn9P1JQtw/Hxl/2h6/ThoaYd+zgjhO9heyafQALUlMpEJw== X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Feb 2022 20:20:39 -0000 Hi Mikael, Am 29.01.22 um 15:24 schrieb Mikael Morin: > Hello, > > the attached patch is a fix for PR104228. > Even if simple, I wouldn=E2=80=99t call it obvious, as it=E2=80=99s invo= lving character > length and associate, so I don=E2=80=99t mind some extra review eyes. I am probably not experienced enough to review this. Paul? Nevertheless, I looked at the commits that introduced the code you touched. It appears that these did not cover, maybe even avoid the current case where the associate target is not a dummy. Your changes seem to make sense and fix the issue. > Tested on x86_64-pc-linux-gnu. Ok for master/11/10/9? OK, and thanks for the patch! Harald