From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.smtpout.orange.fr (smtp-29.smtpout.orange.fr [80.12.242.29]) by sourceware.org (Postfix) with ESMTPS id 21DCE3858D20; Sun, 28 Jan 2024 11:39:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 21DCE3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=orange.fr Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=orange.fr ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 21DCE3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=80.12.242.29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706441961; cv=none; b=VNJLKbuhNWSDGsA9DoDTWEUps9dxxuXlVFtWNI29+TPJ1v5aTHzX3vC4DeOVhApW+SvMocc00Mp3ZYvADz5qhoHXsebkWZJRGinmG+8C4SxJdHh2S8c5E0nbkfYf92QN/Z+UQLImgVplWmIWdbqPkFbhFEX4Xwl9sRsJ+XaZvMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706441961; c=relaxed/simple; bh=qMOTBjHYbvKJQUkYtfWlPJZcowIi58MWvMLHX3/QyFM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=k0Ko9Y7cIG5XhD8CliluqPANCSiIxUFMBV9XzdHjwquxB+TCDa5obgF6MNDB5bCTVYphPs5yuAM8XokBlOuN/d/JGysncF3O37FW5i6bipUqoXg14xeilN+imUc+0xWx5IQ4hMymgtqQ9O6stZfJj5Lb3KEEKh0hAsK+BKV0kdA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [192.168.1.16] ([86.215.161.51]) by smtp.orange.fr with ESMTPA id U3VIrkxBpzLTQU3VOrzI8s; Sun, 28 Jan 2024 12:39:18 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1706441958; bh=6VyNX49pHPUC8UTAn1zKESA70ojxkyMWEmeOOcaoqww=; h=Date:Subject:To:References:From:In-Reply-To; b=buBMMDkv2n8doTQfI2Qt98H+aB6IsPHnDbRJIQqX1h48hf+h5hNSF0bjBaJW8Ucq0 6nwwUqvnlqiKaBl5rVZ9z+4BUMhIolbPMwCn6DvUCgi7pb0uFGdEbhfj2xfiWM5at8 AtIC2ri5Ax74EqYAVARWL+2zKWKUcyaKEkjpo7IhbcUHRHDw0h7B6Fjcpp3mv2YWbj COd6iD/zf0X+cbsDR36LlxZIIvP0PQZEr8cEovDgBB2G6zb5BzZ4GxLKYgDDij9qRH WUtDr7OBwXr+er0dVnTHmsIldExqpas31ycwwp+sXrDgsRYwUr9s/SO1qsQ4CA4jR/ 4wjiG/4/eitJA== X-ME-Helo: [192.168.1.16] X-ME-Auth: bW9yaW4tbWlrYWVsQG9yYW5nZS5mcg== X-ME-Date: Sun, 28 Jan 2024 12:39:18 +0100 X-ME-IP: 86.215.161.51 Message-ID: <67c77b44-79cb-4029-b59a-c92dfad15fa9@orange.fr> Date: Sun, 28 Jan 2024 12:39:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fortran: use name of array component in runtime error message [PR30802] To: Harald Anlauf , fortran , gcc-patches References: Content-Language: en-US From: Mikael Morin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Le 24/01/2024 à 22:39, Harald Anlauf a écrit : > Dear all, > > this patch is actually only a followup fix to generate the proper name > of an array reference in derived-type components for the runtime error > message generated for the bounds-checking code. Without the proper > part ref, not only a user may get confused: I was, too... > > The testcase is compile-only, as it is only important to check the > strings used in the error messages. > > Regtested on x86_64-pc-linux-gnu. OK for mainline? > > Thanks, > Harald > Hello, the change proper looks good, and is an improvement. But I'm a little concerned by the production of references like in the test x1%vv%z which could be confusing and is strictly speaking invalid fortran (multiple non-scalar components). Did you consider generating x1%vv(?,?)%zz or x1%vv(...)%z or similar? There is another nit about the test, which has dg-output and dg-shouldfail despite being only a compile-time test. Otherwise looks good. Mikael