Re: [patch, fortran] Asynchronous I/O, take 3

[Jerry DeLisle <jvdelisle@charter.net>]

On 07/15/2018 10:47 AM, Rainer Orth wrote:
> Hi Thomas,
> 
>>> However, I still don't understand why you insist on the hack with
>>> putting the async_io_*.f90 tests into the libgomp testsuite.  Why not
>>> just make the pthread requirement explicit with
>>>
>>> { dg-require-effective-target pthread }
>>> { dg-additional-options "-pthread" }
>>>
>>> and put them in gfortran.dg where they belong?
>>
>> Because this does not appear to work with Linux. I, like
>> most gfortran developers, work on Linux, and I would like to
>> catch any failure during regression-testing on my own system,
>> if possible.
> 
> huh, what doesn't work?  I've just finished an x86_64-pc-linux-gnu
> bootstrap with your patch included, added the above to the
> async_io_?.f90 tests, linked them to gfortran.dg and ran the tests there
> (both 32 and 64-bit multilibs), all PASSed and I verified that they were
> linked with -lpthread.
> 
>> We have had this discussion with Jakub, and he advised
>> us to put all the stuff requiring pthreads into libgomp.
> 
> Do you have a pointer to that previous discussion?
> 
>> It is debatable if this is a good thing, or if we should
>> at least make one round of tests with -pthread enabled.
>> However, this is something for the future, and requires knowledge
>> of dejagnu that I don't currently have :-)
> 
> First of all, we need to see and understand the failure mode, if any.
> Making this work with the testsuite is a secondary matter only, and I
> can certainly help with that if necessary.
> 
> 	Rainer
> 

Hmm, interesting. Which linux are you using?

I will try it here as well.

Jerry