From: FX <fxcoudert@gmail.com>
To: fortran@gcc.gnu.org
Cc: Iain Sandoe <iain@sandoe.co.uk>, gcc-patches@gcc.gnu.org
Subject: Re: [patch, Fortran] Make REAL(KIND=16) detection more robust
Date: Wed, 15 Dec 2021 09:59:02 +0100 [thread overview]
Message-ID: <6A9D29ED-FE70-4839-B73D-8A1B51950A62@gmail.com> (raw)
In-Reply-To: <8CA66B79-11B1-40B2-B361-F8835EF4DF1B@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]
A gentle ping…
> Le 7 déc. 2021 à 15:11, FX <fxcoudert@gmail.com> a écrit :
>
> Hi,
>
> Right now, the logic in libgfortran for the detection of REAL(KIND=16) is in kinds-override.h:
>
> /* What are the C types corresponding to the real(kind=10) and
> real(kind=16) types? We currently rely on the following assumptions:
> -- if real(kind=10) exists, i.e. if HAVE_GFC_REAL_10 is defined,
> then it is necessarily the "long double" type
> -- if real(kind=16) exists, then:
> * if HAVE_GFC_REAL_10, real(kind=16) is "__float128"
> * otherwise, real(kind=16) is "long double"
> To allow to change this in the future, we create the
> GFC_REAL_16_IS_FLOAT128 macro that is used throughout libgfortran. */
>
>
> Well, this may not be true of all platforms, and it’s possible to have other combinations. On the aarch64-apple-darwin port, I’m currently playing with enabling a binary128 floating-point mode, and that target has double == long double… so the assumptions above are not true.
>
> Funnily, we already have more fine-grained logic in the mk-kinds-h.sh script, where we actually check the Fortran kind corresponding to C’s long double. We just have to use it, and emit the GFC_REAL_16_IS_FLOAT128 / GFC_REAL_16_IS_LONG_DOUBLE macros there.
>
>
> Bootstrapped and regtested on x86_64-linux, checked that no symbols were introduced or removed.
> (and tested on a port to aarch64-apple-darwin).
>
> OK to commit?
>
> FX
[-- Attachment #2: libgfortran.patch --]
[-- Type: application/octet-stream, Size: 2645 bytes --]
commit 6b2a78f168ecf9c6f47e2cbebac121470e81b558
Author: Francois-Xavier Coudert <fxcoudert@gmail.com>
Date: 2021-12-07 12:25:12 +0100
Allow __float128 on tergets where long double is not REAL(KIND=10)
libgfortran/ChangeLog:
* kinds-override.h: Move GFC_REAL_16_IS_* macros...
* mk-kinds-h.sh: ... here.
diff --git a/libgfortran/kinds-override.h b/libgfortran/kinds-override.h
index c9e874a3f38..5f7840b0c89 100644
--- a/libgfortran/kinds-override.h
+++ b/libgfortran/kinds-override.h
@@ -23,24 +23,9 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
<http://www.gnu.org/licenses/>. */
-/* What are the C types corresponding to the real(kind=10) and
- real(kind=16) types? We currently rely on the following assumptions:
- -- if real(kind=10) exists, i.e. if HAVE_GFC_REAL_10 is defined,
- then it is necessarily the "long double" type
- -- if real(kind=16) exists, then:
- * if HAVE_GFC_REAL_10, real(kind=16) is "__float128"
- * otherwise, real(kind=16) is "long double"
- To allow to change this in the future, we create the
- GFC_REAL_16_IS_FLOAT128 macro that is used throughout libgfortran. */
-
-#if defined(HAVE_GFC_REAL_16)
-# if defined(HAVE_GFC_REAL_10)
-# define GFC_REAL_16_IS_FLOAT128
-# if !defined(HAVE_FLOAT128)
-# error "Where has __float128 gone?"
-# endif
-# else
-# define GFC_REAL_16_IS_LONG_DOUBLE
-# endif
+/* Ensure that TFmode is available under. */
+
+#if defined(GFC_REAL_16_IS_FLOAT128) && !defined(HAVE_FLOAT128)
+# error "Where has __float128 gone?"
#endif
diff --git a/libgfortran/mk-kinds-h.sh b/libgfortran/mk-kinds-h.sh
index 249619061c6..572878ce891 100755
--- a/libgfortran/mk-kinds-h.sh
+++ b/libgfortran/mk-kinds-h.sh
@@ -64,15 +64,19 @@ for k in $possible_real_kinds; do
case $k in
4) ctype="float" ; cplxtype="complex float" ; suffix="f" ;;
8) ctype="double" ; cplxtype="complex double" ; suffix="" ;;
+ # If we have a REAL(KIND=10), it is always long double
10) ctype="long double" ; cplxtype="complex long double" ; suffix="l" ;;
- 16) if [ $long_double_kind -eq 10 ]; then
+ # If we have a REAL(KIND=16), it is either long double or __float128
+ 16) if [ $long_double_kind -ne 16 ]; then
ctype="__float128"
cplxtype="_Complex float __attribute__((mode(TC)))"
suffix="q"
+ echo "#define GFC_REAL_16_IS_FLOAT128"
else
ctype="long double"
cplxtype="complex long double"
suffix="l"
+ echo "#define GFC_REAL_16_IS_LONG_DOUBLE"
fi ;;
*) echo "$0: Unknown type" >&2 ; exit 1 ;;
esac
next prev parent reply other threads:[~2021-12-15 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 14:11 FX
2021-12-15 8:59 ` FX [this message]
2021-12-19 21:02 ` Thomas Koenig
2021-12-19 23:42 ` FX
2021-12-20 12:12 ` Thomas Koenig
2021-12-22 11:51 ` FX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A9D29ED-FE70-4839-B73D-8A1B51950A62@gmail.com \
--to=fxcoudert@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).