From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111195 invoked by alias); 3 Apr 2018 15:22:42 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 111168 invoked by uid 89); 3 Apr 2018 15:22:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: nef2.ens.fr Received: from nef2.ens.fr (HELO nef2.ens.fr) (129.199.96.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Apr 2018 15:22:40 +0000 X-ENS-nef-client: 129.199.120.1 Received: from mailhost.lps.ens.fr (tournesol.lps.ens.fr [129.199.120.1]) by nef2.ens.fr (8.13.6/1.01.28121999) with ESMTP id w33FLuds077101 ; Tue, 3 Apr 2018 17:21:57 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailhost.lps.ens.fr (Postfix) with ESMTP id D3673155; Tue, 3 Apr 2018 17:21:56 +0200 (CEST) Received: from mailhost.lps.ens.fr ([127.0.0.1]) by localhost (tournesol.lps.ens.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9BilBqaqFSv2; Tue, 3 Apr 2018 17:21:56 +0200 (CEST) Received: from [192.168.1.11] (log78-1-82-242-47-10.fbx.proxad.net [82.242.47.10]) by mailhost.lps.ens.fr (Postfix) with ESMTPSA id 9DF9F14A; Tue, 3 Apr 2018 17:21:56 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Subject: Re: [patch, fortran] Simplify constants which come from parameter arrays From: =?utf-8?Q?Dominique_d=27Humi=C3=A8res?= In-Reply-To: Date: Tue, 03 Apr 2018 15:22:00 -0000 Cc: gfortran , gcc-patches Content-Transfer-Encoding: quoted-printable Message-Id: <6FD16B0D-6267-459E-A839-A49574D9C5FE@lps.ens.fr> References: <51CF16C7-D140-45B3-A4BC-72FA60FF4E9A@lps.ens.fr> To: =?utf-8?Q?Thomas_K=C3=B6nig?= X-SW-Source: 2018-04/txt/msg00008.txt.bz2 Hi Thomas, > Le 31 mars 2018 =C3=A0 13:57, Thomas K=C3=B6nig a =C3=A9= crit : >=20 > Hi Dominique, >=20 > These have been resolved now - I have removed the invalid code > from substr_6.f90 (PR85130), and the error is now suppressed > in the attached patch. >=20 > Re-regression-tested. OK for trunk? >=20 > Regards The new patch regtest fine now. However as said on IRC this looks as a klud= ge made necessary by a questionable (invalid) test. IMO it would be more general (better) to call gfc_simplify_expr (e, 1); only when there is no pending error (warning?). I have also a question about "is out of bounds": it is a warning in resolve= .c, but an error in expr.c and simplify.c. Should not it be an error everyw= here? Cheers, Dominique