From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 2DCFA3858D34; Fri, 5 Apr 2024 17:47:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DCFA3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2DCFA3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712339228; cv=none; b=muXUYBwKT/WdT1DGYmp/y0gCh9thClZ1TiYxeP3hhbGpUIgEWQQE2VsVADT9S3rQLAasjWi79ilJxNHMHeIIZ9yid38RYsn56zC6CZAgklrmHDlH6kWGjc0OZNWvU6trUszNWdvE2h1mYlinz7fCtdVuetkyhKLOGY/JEYkHyNU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712339228; c=relaxed/simple; bh=z1nw+NzYHCdDbPKSoiuTm2lqUg77fNRlR3H8YOGb1rc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=C6tnmLJP9bHawFEvzCCu48QydlQH2hBu3awlwWEujUbt/SCWysUtsvA7s6JjJSSd7P3nEDDFyKenVSGLF3iSTT+cGgUmrzYQrMQU/OopJ0cgimqS3btRnLw68iKoOHq8YZfdj97mKPfe/apCRmAWPELQkiwZpBB+LmZwB8BeKe8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1e21db621caso4846405ad.0; Fri, 05 Apr 2024 10:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712339226; x=1712944026; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=aPMXxpL3fGO+J0DcoaFgjwK03nDbg9tj84OSUFBq57A=; b=f9nXwJukVU2T0bZ/bfMHw/1kbToqzU300ZM/hXexgjNfg4kdFEWa/afk/wjjDJAkuM MBBjJfWVUquDslwgtHEIuM4IAgzp0qycF2EeLTOHXYXoSWU1aXC1TLasi4h2tc8XZsp/ jNvhHwv7J52FXzDf/iOkeoYfBfNHGVJiR3xSsDGR/oNYe6EoYRH6Pmvq0+lHi3RN1wZ/ LkI+l0nDXsrgkft+RZhez27vLP1vzwsNxe8mRBmCA0jeoI9O8ub/Xof1633XvFuHgwe+ fBiMAXtbaz4d5YFPxnNxC+TT7/xByFOu93WIsgRgwavpYolCqiCa1exIidmqfD2ow5ct aDJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712339226; x=1712944026; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aPMXxpL3fGO+J0DcoaFgjwK03nDbg9tj84OSUFBq57A=; b=Ck0Hd1Pem4fFLin+nO/Nyw9hp/IxZ1jF783JUe1GUWHD98LPR/S/mxbQlB7SWE7unD 18MQTmaYgB0xk+4oKfiLawu8IIoyY5x5RHkydLHJrhKWxnSlptyecbdYrpNgu2yAtWkN ZgkcID/DRAN/C8LEjaFHI8t5LpATFbRuNye3lTCduoKSmYeoi56gDZBFT9Di5D46ElhX tdPmV6ZHzYjDr9YdbMLHEZtaj/7wetJnk9L0tvivpinBj8HnCMT9EFeX/NO8SQQ19pDn iwWQZ9GqlQh3CnQHnRwJWn5lDY//P5z1A0sb+/NSPSuONs9Ia/z58SIOD02jj8tIrH8M n60w== X-Forwarded-Encrypted: i=1; AJvYcCWFUbQ+L5kBOVB3Ae/2QLrDWccnsYkTNvE/5uewyH6O11/QIS/2KOQwXyZGe4yVzfzLR841XFoupcZMLPH8aWwOqGOw X-Gm-Message-State: AOJu0YxYMo7/RuAG5Z+Wnof3zFImbwMyGb1suMChMZDwb5FV0ban6Dal v74Y5zR+jbSZjOLpgtr/K9lbTlmFZEJ7/NWah1X5ub/n6OtNHJcn X-Google-Smtp-Source: AGHT+IHY+MTPX2t0mH/dvp1HKSLsM115MqeGvkvF/f56ZYnnSoeje35Eu5DDrmmxOS5DCA42tGoG5g== X-Received: by 2002:a17:902:ecd2:b0:1dd:e128:16b1 with SMTP id a18-20020a170902ecd200b001dde12816b1mr2281782plh.6.1712339225954; Fri, 05 Apr 2024 10:47:05 -0700 (PDT) Received: from [192.168.1.20] ([50.37.177.113]) by smtp.gmail.com with ESMTPSA id l6-20020a170902d34600b001dd0c5d5227sm1854208plk.193.2024.04.05.10.47.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 10:47:05 -0700 (PDT) Message-ID: <6a742cef-5321-4b34-a2f0-870abd1ba82a@gmail.com> Date: Fri, 5 Apr 2024 10:47:04 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?Q?Re=3A_=5Bpatch=2C_libgfortran=5D_PR114304_-_=5B13/14_Regr?= =?UTF-8?Q?ession=5D_libgfortran_I/O_=E2=80=93_bogus_=22Semicolon_not_allowe?= =?UTF-8?Q?d_as_separator_with_DECIMAL=3D=27point=27=22?= To: Tobias Burnus , gfortran Cc: gcc-patches , Jerry D References: <9a848b89-ee95-44f7-8491-cbe22804edf4@gmail.com> <15a39ada-c7fc-433d-ab39-19b897a8a3e8@baylibre.com> Content-Language: en-US From: Jerry D Autocrypt: addr=jvdelisle2@gmail.com; keydata= xjMEY5TlkxYJKwYBBAHaRw8BAQdAyrkRDhmJhSTTlV/50gJLlvliU6/Lm5C9ViKV8T9y1GnN HkplcnJ5IEQgPGp2ZGVsaXNsZTJAZ21haWwuY29tPsKJBBMWCAAxFiEEOFR0TS0390uh8dRV uWXAJaWpwWoFAmOU5ZMCGwMECwkIBwUVCAkKCwUWAgMBAAAKCRC5ZcAlpanBalsJAP4wdCiH 2Of9oZv1QWgZ/AVdbWFM3Fv47/WZQHOXfoZ9HgD6AkXrKeJ+6usST7PEaDJjptaViT1fLiYY V/6XaOKSsgLOOARjlOWTEgorBgEEAZdVAQUBAQdAdA7PczYnl07vnOT9oP/wvvMDd4HP09Zl g3LzwXQJWT8DAQgHwngEGBYIACAWIQQ4VHRNLTf3S6Hx1FW5ZcAlpanBagUCY5TlkwIbDAAK CRC5ZcAlpanBasF/AQCa5WjlsVpLsEiggZyT18MOJNAdeRd7wkGDUrwedHrvawD/cE1H+/Ms L1ZwvQiLfGdx8crigQqWTQyos4kH8Wx82wc= In-Reply-To: <15a39ada-c7fc-433d-ab39-19b897a8a3e8@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/4/24 2:41 PM, Tobias Burnus wrote: > Hi Jerry, > > I think for the current testcases, I like the patch – the question is > only what's about: > >   ',3' as input for 'comma'   (or '.3' as input for 'point') > > For 'point' – 0.3 is read and ios = 0 (as expected) > But for 'comma': > * GCC 12 reads nothing and has ios = 0. > * GCC 13/mainline has an error (ios != 0 – and reads nothing) > * GCC with your patch: Same result: ios != 0 and nothing read. > > Expected: Same as with ','/'comma' – namely: read-in value is 0.3. > → https://godbolt.org/z/4rc8fz4sT for the full example, which works with > ifort, ifx and flang > > * * * > > Can you check and fix this? It looks perfectly valid to me to have > remove the '0' in the floating point numbers '0.3' or '0,3' seems to be > permitted – and it works for '.' (with 'point') but not for ',' (with > 'comma'). > Yes, I found the spot to fix this. > F2023's "13.10.3.1 List-directed input forms" refers to "13.7.2.3.2 F > editing", which states: > > "The standard form of the input field [...] The form of the mantissa is > an optional sign, followed by a string of one or more digits optionally > containing a decimal symbol." > > The latter does not require that the digit has to be before the decimal > sign and as for output, it is optional, it is surely intended that ",3" > is a valid floating-point number for decimal='comma'. > Agree > * * * > > I extended the testcase to check for this – see attached diff. All > 'point' work, all 'comma' fail. > > Thanks for working on this! > > Tobias Thanks much. After I fix it, I will use your extended test case in the test suite. Jerry -