From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.smtpout.orange.fr (smtp-25.smtpout.orange.fr [80.12.242.25]) by sourceware.org (Postfix) with ESMTPS id E6B5B3858D28; Thu, 21 Mar 2024 13:07:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E6B5B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=orange.fr ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E6B5B3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=80.12.242.25 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711026455; cv=none; b=SY4h5BekslbMDzFa9Xuu2tT3U1uBCGG4V6LWkZqlPkXUCUU19J5a2n3kYaZO+1pK/QwXJJi5EmAPvK/p0UQ3LhJ3W9MmzJWzK2CHu0mrPPlYG/jDEH7hCyZXcHhMgOxeDSI/tBikGGiLM9FW46cT0PnlkfE+0FAnUm495slOfMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711026455; c=relaxed/simple; bh=QhhcEv/Xr/1mW6rFGKcmhwxM7pYveydWfRFT6l0S1V0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vwHNKdyq9CrRGudCLBx03Fhxm1BxryDD1uBmAyqqQCCgR0IHinycA5UZbBdKbYMOzp6CwwMCfd+n0Fvfy6fkqUUlQKjd3NICy76VqAZC3isCIrPDx9515qBoD8QlOnONjGiTANCbFkm94ALKHdDnwahVtK2ag7aLSyA7NZTudZg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [192.168.1.19] ([86.215.161.51]) by smtp.orange.fr with ESMTPA id nI8Zr2BEnmbfZnI8erJuAi; Thu, 21 Mar 2024 14:07:23 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1711026443; bh=Q3aBvZ706pJnrkr4vljg9Q7vTenO4IwA+vLzyZDJ+K0=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=WffojPEvFh7QidpJN33Neo+z86HQs1JAHkS8MJ/GGo0NlA52R/nooKlEGPp4AfvpP AMCo3pxrSBhsj3yqqClaXxDFXThmpFddxeeTDr7HZ07e4WK5r39IfovbD+8lVtRMRg BI3nOr00MclebbZSBOYlnH2xMScVCeZ9tJbMBDIuADHBU6D/m1tikqjAs6cysmRZ53 yIctD6IOu7sfU8TTZJcicok/qZqSzvd22pwmXuDoYg09aBG7+VDmf7AHUqN95epVFR czVsf6VnNHX54KHFQBAcAu6Lwzs9xQuWRpFQ1qPhXjB7yj+BE4AYv32VIczKPjuDa0 ftG949J6OdbXg== X-ME-Helo: [192.168.1.19] X-ME-Auth: bW9yaW4tbWlrYWVsQG9yYW5nZS5mcg== X-ME-Date: Thu, 21 Mar 2024 14:07:23 +0100 X-ME-IP: 86.215.161.51 Message-ID: <6e2444f2-ae34-4482-87fd-b924d0f6811b@orange.fr> Date: Thu, 21 Mar 2024 14:07:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH, v3] Fortran: improve array component description in runtime error message [PR30802] To: Harald Anlauf , sgk@troutmask.apl.washington.edu Cc: fortran , gcc-patches References: <67c77b44-79cb-4029-b59a-c92dfad15fa9@orange.fr> <86888cc5-3650-4044-b67d-89aab1631753@gmx.de> <70fc4304-74b4-4d8c-8172-9c3286bc9ada@gmx.de> <50f2a7c0-55af-4079-9f6f-41dc6497c234@orange.fr> <04f84bdb-4589-444a-93af-9e252908da93@orange.fr> <6d15efdc-cc99-4008-b0e7-9091a9cebced@orange.fr> <998a971e-1614-42b8-87c7-6c85c33b16e6@orange.fr> <8dd61d1e-a5ed-4305-b483-e845734e8a4d@gmx.de> Content-Language: fr From: Mikael Morin In-Reply-To: <8dd61d1e-a5ed-4305-b483-e845734e8a4d@gmx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Le 20/03/2024 à 21:24, Harald Anlauf a écrit : > Hi Mikael, all, > > here's now the third version of the patch that implements the following > scheme: > > On 3/15/24 20:29, Mikael Morin wrote: >> Le 15/03/2024 à 18:26, Harald Anlauf a écrit : >>> OK, that sounds interesting.  To clarify the options: >>> >>> - for ordinary array x it would stay 'x' >>> >>> - when z is a DT scalar, and z%x is the array in question, use 'z%x' >>>    (here z...%x would look strange to me) >>> >> Yes, the ellipsis would look strange to me as well. >> >>> - when z is a DT array, and x some component further down, 'z...%x' >>> >> This case also applies when z is a DT scalar and x is more than one >> level deep. >> >>> I would rather not make the error message text vary too much to avoid >>> to run into issues with translation.  Would it be fine with you to have >>> >>> ... dimension 1 of array 'z...%x' above array bound ... >>> >>> only? >>> >> OK, let's drop "component". >> >>> Anything else? >>> >> No, I think you covered everything. > > I've created a new helper function that centralizes the generation of > the abbreviated name of the array (component) and use it to simplify > related code in multiple places.  If we change our mind how a bounds > violation error message should look like, it will be easier to adjust > in the future. > > Is this OK for 14-mainline? > Yes, thanks. > Thanks, > Harald > >