From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 8419C3850206; Wed, 29 Jun 2022 14:42:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8419C3850206 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.92,231,1650960000"; d="scan'208";a="77926397" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 29 Jun 2022 06:42:51 -0800 IronPort-SDR: RL+TWgfIBp91OTXL7PXLxNcnaby47gUpUJHt4z0O6Ctcm7q5rDRtZ+Q5LpUWT7AFekx+J/DPCv 0zVg7KZlZmur5wuQm4yfdkenR019r3nqtvs0nuNSWQ2Ak6hFWYBbzpOkz9zvjBn4/RqaYrmVFs 1/Ir/MI0UbnWmMXYVoeDGqHQY3B/or5wQJ//YoYfOAeP4vsG2qf0n1m1xq6s1IGF/ZQfk6/GWZ Z1xo7eioKr+0ctE7J8GsxNzwIEmEIv9V6lSCq5RPFxVRMs7WQE643EsPtcm5wkqYx4mhJTrehe spk= Message-ID: <6f4ceb9a-ba6b-d514-7623-7ce95cfba8e2@codesourcery.com> Date: Wed, 29 Jun 2022 16:42:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] libgfortran: Fix up LIBGFOR_CHECK_FLOAT128 [PR106137] Content-Language: en-US To: Jakub Jelinek , , References: From: Tobias Burnus In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 14:42:55 -0000 On 29.06.22 14:13, Jakub Jelinek via Fortran wrote: > My recent gfortran + libgfortran patch apparently broke (some?) aarch64 > builds. While it is desirable to use just _Float128 rather than __float1= 28, > we only want to use it (and e.g. define HAVE_FLOAT128) on targets where > _Float128 is supported and long double isn't IEEE quad precision. > Which is targets that support __float128 type which we have been testing > for before - _Float128 is supported on those targets and on targets where > long double is IEEE quad precision. > > So, the following patch restores check for whether __float128 is supporte= d > into the LIBGFOR_CHECK_FLOAT128 check which determines whether > HAVE_FLOAT128 is defined or whether to use libquadmath, so that e.g. on > aarch64 where long double is IEEE quad we don't do that. > > Tested by Tamar on aarch64 and by me on x86_64-linux, ok for trunk? > 2022-06-29 Jakub Jelinek > > PR bootstrap/106137 > * acinclude.m4 (LIBGFOR_CHECK_FLOAT128): Also test for __float128. > * configure: Regenerated. > > --- libgfortran/acinclude.m4.jj 2022-06-28 13:14:45.327799267 +0200 > +++ libgfortran/acinclude.m4 2022-06-29 11:45:19.286551469 +0200 > @@ -276,7 +276,6 @@ AC_DEFUN([LIBGFOR_CHECK_FLOAT128], [ > GCC_TRY_COMPILE_OR_LINK([ > _Float128 foo (_Float128 x) ... > + __float128 baz (__float128 x) As now both __float128 and _Float128 is tested, can you also update: dnl Check whether we have a __float128 type AC_DEFUN([LIBGFOR_CHECK_FLOAT128], [ ... AC_CACHE_CHECK([whether we have a usable _Float128 type], libgfor_cv_have_float128, [ I note that your follow-up patch adds _Float128 to the dnl comment, but I think __float128 should also be added to the cache output to make clear that both _Float128/__float128 are checked. Otherwise: LGTM. Thanks, Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955