From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=IFm5=FE=gmx.de=anlauf@sourceware.org>
Received: from mout.gmx.net (mout.gmx.net [212.227.17.20])
	by sourceware.org (Postfix) with ESMTPS id CA5B33858D1E;
	Wed, 20 Sep 2023 17:36:24 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA5B33858D1E
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417;
 t=1695231382; x=1695836182; i=anlauf@gmx.de;
 bh=XelrmSDkIhYxPjMSg6QEPbNzdzrQwO2jN79zQ28fhys=;
 h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To;
 b=Dn4w7nyYBhHDzbjchmTA9BRIkuQlLrAmz6YywIL2op2sOYN7jkN5n1N55Pw/+sANaTxH3/lSZdK
 OG3r1tFdWta2ZywOt41Ld6rm8Qs0O2ZuHqLbUtd2iB99kf5BS3UlS5/YM9EA/Eym81CH6yxuBq6F+
 wHds9koiAq3We4fIgwZ4WbHP7TuQIzBce2y5ooRBbycRs5p/iqbkqTQ/6+lsaASebmS4k/cMKd01k
 xf4aoFdxxgWwFCdXFN3CkU/gSkzlOK5QLczMB6IEl7gSA5W1T4arSCR6O40AbiNBqyK2zOv2cRDCp
 BWBMk1qZSzjxJW/CHgawpF8tUKrSnOmZ3LZQ==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from [192.168.178.29] ([79.251.11.57]) by mail.gmx.net (mrgmx105
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MrQEx-1rVo0X1GUx-00oYaS; Wed, 20
 Sep 2023 19:36:22 +0200
Message-ID: <6fb1f1a0-7ba3-4d6b-9282-de0443ef0bb8@gmx.de>
Date: Wed, 20 Sep 2023 19:36:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [Patch, fortran] PR68155 - ICE on initializing character array in
 type (len_lhs <> len_rhs)
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>,
 "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
 gcc-patches <gcc-patches@gcc.gnu.org>
Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran
References: <CAGkQGiJW7-4N-CkL5mH2K+RQomL9pYmZVZvDUjYdMUHHd+5UBA@mail.gmail.com>
Content-Language: en-US
From: Harald Anlauf <anlauf@gmx.de>
In-Reply-To: <CAGkQGiJW7-4N-CkL5mH2K+RQomL9pYmZVZvDUjYdMUHHd+5UBA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:IotwEgypS/A130/lVkGyTi8FuGA7jvh/FAmsE7fqcaSxS73y4dR
 PPB8ohvuSbtFeLIppGUf6wFyGcP3hl2Ukw1Ppw+D97ng1nY5/nFCtwsam/guxOtm0g2HiOL
 Q8RdTWEVZ6uEUg55ZrugOkN0w8X0ip65QpR8C121GO4UHLRcEjDwRYC0Ek8EsBXVjSH9Zt4
 +ODZXdI2xLlnqUEpnympA==
UI-OutboundReport: notjunk:1;M01:P0:RN9O1ke5H7o=;PcXatcemc7hxB2zAB95wiGZRjx9
 4Y2lQ9dnBMg9eqjVRTakrbfNbRLxAG6eUFbgFPCg66yMfGIYtMhooUgdzW/7cpnifmk4WwU4L
 HtrPn/oHtcyxJxvNSGOOPqwgKE+RCfd2kgzjCf3qcYFhlKJlcR32d4B7otyRr4yE4NXOogFEa
 njoeuR5/codIUurp26YfO8PNcszyPdKNm8Ta2fmeL3GrCPBItHm0C6zCf0C0n+kxY75eQLrDa
 oZGp3aS1C4WDN6fAU5APLRhB74MVTxz+U2J7BmzgcBbI+s+0Q3DoZSwj/krOURobUbB5qR5+u
 IpQKuvaGFx1szgzYp7dFddlCIjz+hLiB3PkgdguxpOTZ6hnRMRaBPalI8Ox5Utq097hkcSOtW
 bMH8ZU+2Av1d8m2oWwHbs85Nj3kRGVgkutF54wWyE/nih18SlajKmvlFv0OzrgYwvjYQ9IBJT
 5JOQPaXld4c29Rd/1ElmHzQmFYpTJnc7gjw5v/U9tAYPt6Eqx6fCGDUgF6fb2tfraR2GYCMYM
 ZY4b/uFR2DjAbI4xNNnNnqpJ8ffiRco5b4OcOIek2UC+wJaotF2ISqHN5iBGlJpKy58TVrm13
 0iAtI5N8dlzsFpmIccI0vJf1VFDh6Fyfv5WlcibAaD/CTVYjP/KfivN47LfHJLRsdfp8brxzw
 b6CxGoGjCd38KJeaLltfk4fewqPm0LI517eR1z34A/BBrQrUnpSTVVl6jZ7LKnfLDk0p1AS22
 T2B3pb55Oz4R1C5ZHf80OPUiSi1kNSrDH1Eu23D++ovDgLWISpMxK7J+omfoIE42Dzp5b3UEL
 hOmv/yE1JHTKDvVJNB103eLg2bMrWkwgzws6YQNsAR3mR0lBHNS3jp7cKJ7O51tQytDmFyspc
 pdAEHRPXBllOs34bMOEW7PlwKiC5/qMJL2IeIOyPGEZKUfDlpHfcB8E6hhOGMnmRWk9t7aKkE
 556cSyCYEXx/YA9NP04sROqFoRQ=
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <fortran.gcc.gnu.org>

Hi Paul,

On 9/20/23 09:03, Paul Richard Thomas wrote:
> Hi All,
>
> This is a straightforward patch that is adequately explained by the Chan=
geLog.
>
> Regtests fine - OK for trunk?

this looks good to me.  OK for trunk.

As it is an almost obvious fix for sort of wrong code, I'd consider
it backportable if you have intentions in that direction.

Thanks,
Harald

> Cheers
>
> Paul
>
> Fortran: Pad mismatched charlens in component initializers [PR68155]
>
> 2023-09-20  Paul Thomas  <pault@gcc.gnu.org>
>
> gcc/fortran
> PR fortran/68155
> * decl.cc (fix_initializer_charlen): New function broken out of
> add_init_expr_to_sym.
> (add_init_expr_to_sym, build_struct): Call the new function.
>
> gcc/testsuite/
> PR fortran/68155
> * gfortran.dg/pr68155.f90: New test.