public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Thomas Koenig <tkoenig@netcologne.de>
To: Mark Eggleston <mark.eggleston@codethink.co.uk>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	fortran <fortran@gcc.gnu.org>
Subject: Re: [PATCH] Fortran : ICE in gfc_validate_kind PR96099
Date: Sun, 4 Oct 2020 12:33:23 +0200	[thread overview]
Message-ID: <702c7799-6030-ea04-d831-9901c0f63f47@netcologne.de> (raw)
In-Reply-To: <0ae4999a-3814-7e25-705c-23058c6c3ecf@codethink.co.uk>

Hi Mark,

> This is a follow up to PR95586 which fixed only the ICE that occurred 
> when using derived types in an implicit statement.  The ICE occurred 
> because an attempt was made to determine kind for types that do not have 
> kinds.
> 
> This patch ensures that kind is only determined for types that support 
> kind.
> 
> OK for master?

OK.

> Is it worth backporting?

As an ICE on invalid for quite a special case, I'd say probably
not.

Thanks for the patch!

Best regards

	Thomas

      reply	other threads:[~2020-10-04 10:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02  5:51 Mark Eggleston
2020-10-04 10:33 ` Thomas Koenig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=702c7799-6030-ea04-d831-9901c0f63f47@netcologne.de \
    --to=tkoenig@netcologne.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mark.eggleston@codethink.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).