From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tkoenig@netcologne.de>
Received: from cc-smtpout1.netcologne.de (cc-smtpout1.netcologne.de
 [89.1.8.211])
 by sourceware.org (Postfix) with ESMTPS id B8994384400F;
 Sun,  4 Oct 2020 10:33:27 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B8994384400F
Received: from cc-smtpin2.netcologne.de (cc-smtpin2.netcologne.de [89.1.8.202])
 by cc-smtpout1.netcologne.de (Postfix) with ESMTP id 8B30513102;
 Sun,  4 Oct 2020 12:33:26 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by cc-smtpin2.netcologne.de (Postfix) with ESMTP id 87A7011E92;
 Sun,  4 Oct 2020 12:33:26 +0200 (CEST)
Received: from [2001:4dd7:37fd:0:f24a:ef02:db5e:204f]
 (helo=cc-smtpin2.netcologne.de)
 by localhost with ESMTP (eXpurgate 4.11.6)
 (envelope-from <tkoenig@netcologne.de>)
 id 5f79a4f6-024d-7f0000012729-7f000001cd0c-1
 for <multiple-recipients>; Sun, 04 Oct 2020 12:33:26 +0200
Received: from linux-p51k.fritz.box
 (2001-4dd7-37fd-0-f24a-ef02-db5e-204f.ipv6dyn.netcologne.de
 [IPv6:2001:4dd7:37fd:0:f24a:ef02:db5e:204f])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by cc-smtpin2.netcologne.de (Postfix) with ESMTPSA;
 Sun,  4 Oct 2020 12:33:23 +0200 (CEST)
Subject: Re: [PATCH] Fortran : ICE in gfc_validate_kind PR96099
To: Mark Eggleston <mark.eggleston@codethink.co.uk>,
 gcc-patches <gcc-patches@gcc.gnu.org>, fortran <fortran@gcc.gnu.org>
References: <0ae4999a-3814-7e25-705c-23058c6c3ecf@codethink.co.uk>
From: Thomas Koenig <tkoenig@netcologne.de>
Message-ID: <702c7799-6030-ea04-d831-9901c0f63f47@netcologne.de>
Date: Sun, 4 Oct 2020 12:33:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <0ae4999a-3814-7e25-705c-23058c6c3ecf@codethink.co.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: de-DE
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, NICE_REPLY_A,
 RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: fortran@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Fortran mailing list <fortran.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/fortran/>
List-Help: <mailto:fortran-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Oct 2020 10:33:28 -0000

Hi Mark,

> This is a follow up to PR95586 which fixed only the ICE that occurred 
> when using derived types in an implicit statement.  The ICE occurred 
> because an attempt was made to determine kind for types that do not have 
> kinds.
> 
> This patch ensures that kind is only determined for types that support 
> kind.
> 
> OK for master?

OK.

> Is it worth backporting?

As an ICE on invalid for quite a special case, I'd say probably
not.

Thanks for the patch!

Best regards

	Thomas