From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9E4BC3858D1E for ; Tue, 20 Jun 2023 00:54:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E4BC3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687222448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qFp7j+rFSHYcjdpjzVqR09qlprSwHxJtKmCln8mGKhA=; b=ADRFTsoTkeFIVCpbzi/mJRyF5T9aCKfJ8Qn+rOfi5PKcgdcwCgAWGOq4oyYgjkaRlf+PpG 6oNqtRfidX/LuOtMtEvOXGxFaqWwgsKd51m4OddHCCKAsk+ShpLhis16y3GR1XW4oF9hor Mrh5CFPGqHMtSWjApiGQ7KxX8r84jjM= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-RT1M713pMKGl0uFbTKTG0Q-1; Mon, 19 Jun 2023 20:54:07 -0400 X-MC-Unique: RT1M713pMKGl0uFbTKTG0Q-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-763a2ed3a21so62278085a.0 for ; Mon, 19 Jun 2023 17:54:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687222446; x=1689814446; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qFp7j+rFSHYcjdpjzVqR09qlprSwHxJtKmCln8mGKhA=; b=RneUf9iOK/ICtMP5m+1c/TAI23oOHxrq3TLvgFWB/zwJx3+kWzT5SeIB0X2HTOuQum P65+WNhZ1ZHhWHHE0UGgKnCwMrSgFQJvg8o8e1UAS9EMYVqSDr8ywZh4NBaLBLwIoWcf BEb9aG8BGUt5ZWPXTUukNoYJaTumrYUHTQ847721BdXdV90IQ9mdZ7i/AV6K7LuCOQCZ 6WxrdvporPNo6OpQYSGwhEGOoxWj0IM1uqF4cAZ9dU6X0VVQluYzGc6nH1hjDKhuAgw/ Poz52Ztn8wbOnIy+SZqAJs1mVYLgzpoS+UNuJ7Jl/sVsM3QPUOyvyGpZE1WKnd0yZbDv QrtA== X-Gm-Message-State: AC+VfDxvRNiiAA/6EzzrB/F1H+aty9Sj9F2DRc6BCloQ9OTT/52Cb86s GxyCLpE5B+E1I3sCk086/yrrOhOZD5+oksqE64/qK/eolT8Z4NPP9e411RIsf2FlzP4jxpyG86Y ZGqtJzKlF2mxl X-Received: by 2002:a05:620a:2115:b0:762:33a5:d037 with SMTP id l21-20020a05620a211500b0076233a5d037mr10633134qkl.27.1687222446631; Mon, 19 Jun 2023 17:54:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5VHJulxjdO3UQrCCiSCMemvW3Wuaj9vwiSPDTjdrUjBBA+rsC1/q1/z9BhnH/o4RObzBVrXA== X-Received: by 2002:a05:620a:2115:b0:762:33a5:d037 with SMTP id l21-20020a05620a211500b0076233a5d037mr10633122qkl.27.1687222446395; Mon, 19 Jun 2023 17:54:06 -0700 (PDT) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id d7-20020ac86147000000b003eabcc29132sm501810qtm.29.2023.06.19.17.54.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 17:54:05 -0700 (PDT) Message-ID: <7047aaa7-289e-e5d8-c01d-7cbb5275da6a@redhat.com> Date: Mon, 19 Jun 2023 20:54:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v6 0/4] P1689R5 support To: Ben Boeckel Cc: Maxim Kuvyrkov , gcc-patches , nathan@acm.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org, brad.king@kitware.com References: <20230606205025.3164738-1-ben.boeckel@kitware.com> <444B887D-CA74-47EF-AD02-F17D000FE9A4@linaro.org> <20230616194856.GA24524@farprobe> <20230617144332.GB36863@farprobe> From: Jason Merrill In-Reply-To: <20230617144332.GB36863@farprobe> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/17/23 10:43, Ben Boeckel wrote: > On Fri, Jun 16, 2023 at 23:55:53 -0400, Jason Merrill wrote: >> I see the same thing with patch 4 on x86_64-pc-linux-gnu, e.g. >> >> FAIL: g++.dg/modules/ben-1_a.C -std=c++17 (test for excess errors) >> Excess errors: >> /home/jason/gt/gcc/testsuite/g++.dg/modules/ben-1_a.C:9:1: internal >> compiler error: Segmentation fault >> 0x19e2f3c crash_signal >> /home/jason/gt/gcc/toplev.cc:314 >> 0x340f3f8 mkdeps::vec::size() const >> /home/jason/gt/libcpp/mkdeps.cc:57 >> 0x340dc1f apply_vpath >> /home/jason/gt/libcpp/mkdeps.cc:194 >> 0x340e08e deps_add_dep(mkdeps*, char const*) >> /home/jason/gt/libcpp/mkdeps.cc:318 >> 0xea7b51 module_client::open_module_client(unsigned int, char const*, >> mkdeps*, void (*)(char const*), char const*) >> /home/jason/gt/gcc/cp/mapper-client.cc:291 >> 0xef2ba8 make_mapper >> /home/jason/gt/gcc/cp/module.cc:14042 >> 0xf0896c get_mapper(unsigned int, mkdeps*) >> /home/jason/gt/gcc/cp/module.cc:3977 >> 0xf032ac name_pending_imports >> /home/jason/gt/gcc/cp/module.cc:19623 >> 0xf03a7d preprocessed_module(cpp_reader*) >> /home/jason/gt/gcc/cp/module.cc:19817 >> 0xe85104 module_token_cdtor(cpp_reader*, unsigned long) >> /home/jason/gt/gcc/cp/lex.cc:548 >> 0xf467b2 cp_lexer_new_main >> /home/jason/gt/gcc/cp/parser.cc:756 >> 0xfc1e3a c_parse_file() >> /home/jason/gt/gcc/cp/parser.cc:49725 >> 0x11c5bf5 c_common_parse_file() >> /home/jason/gt/gcc/c-family/c-opts.cc:1268 > > Thanks. I missed a `nullptr` check before calling `deps_add_dep`. I > think I got misled by `make check` returning a zero exit code even if > there are failures. Aha! Patches 3 and 4 could also use testcases. Jason