From: Thomas Koenig <tkoenig@netcologne.de>
To: Tobias Burnus <tobias@codesourcery.com>,
Jorge D'Elia <jdelia@cimec.unl.edu.ar>,
Gfortran List <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] Fortran: Fix Array dependency with local coarrays [PR98913] (was: Re: A question about coarrays and -Warray-temporaries)
Date: Tue, 2 Feb 2021 15:54:23 +0100 [thread overview]
Message-ID: <7098734c-32bb-a5d0-1e72-015e33321dc9@netcologne.de> (raw)
In-Reply-To: <4fc42e9c-676d-f3fc-57ab-f665a679bfbb@codesourcery.com>
Am 02.02.21 um 12:46 schrieb Tobias Burnus:
> Hi all,
>
> the attached patch now handles -fcoarray=single and access to the local
> image like no coarray access, using the same check a before.
>
> Actually, I think we could remove the if (..coarray..) check completely:
> For 'single', it is like no coarrays; for 'lib' both AA[remote] =... and
> "AA = ... AA[remove]" will create a function call and uses already
> temporaries. I don't know what 'native'/'threads' does – but either it
> the image index is different, then no temporary is needed at all – or it
> is the same (in particular: this_image / not present), but then the
> noncoarray analysis would work.
That analysis is correct, also as far as the shared memory coarray goes
(where you do offsets as an extra dimension, either it points to the
same memory or to different memory).
So, while your patch is OK, I think a simple removal of the test
is also OK.
Take your pick :-)
Best regards
Thomas
next prev parent reply other threads:[~2021-02-02 14:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 15:51 A question about coarrays and -Warray-temporaries Jorge D'Elia
2021-02-01 7:42 ` Thomas Koenig
2021-02-01 10:43 ` Jorge D'Elia
2021-02-01 11:52 ` Tobias Burnus
2021-02-02 11:46 ` [Patch] Fortran: Fix Array dependency with local coarrays [PR98913] (was: Re: A question about coarrays and -Warray-temporaries) Tobias Burnus
2021-02-02 14:32 ` Jorge D'Elia
2021-02-02 14:54 ` Thomas Koenig [this message]
2021-02-02 17:15 ` Tobias Burnus
2021-02-09 11:52 ` [Patch] Fortran: Fix coarray handling for gfc_dep_resolver [PR99010] (was: Re: [Patch] Fortran: Fix Array dependency with local coarrays [PR98913] Tobias Burnus
2021-02-13 19:57 ` Tobias Burnus
2021-02-19 9:33 ` *PING**2 " Tobias Burnus
2021-02-19 16:25 ` Jerry DeLisle
2021-03-21 16:18 ` A doubt about lbound and ubound of an array inside a coarray Jorge D'Elia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7098734c-32bb-a5d0-1e72-015e33321dc9@netcologne.de \
--to=tkoenig@netcologne.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jdelia@cimec.unl.edu.ar \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).