From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 351213858D3C for ; Thu, 22 Jun 2023 21:21:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 351213858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687468907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F0mx9jrxaCUPAUyvvuyEyQm8iB06V46NLUYE7mR/4q4=; b=L1graY6bNTNB5BKSqlsJ4d0tqHZrjjFC8PMR+fBm6gcrPA0e7T2mA2nnG67DJuiWlNYzx6 biKS9NW3MMYiUn1e2pZVEr8dz3wumEZ91ZaerzWdDO7FFnYMgB5edPbaxh5gmT3dmmKpRJ Gi7wUaM7pgsrjw0NNYo2K2sn20ZvR20= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-451-WXH62yMEO7SvpuOCHrM8mQ-1; Thu, 22 Jun 2023 17:21:46 -0400 X-MC-Unique: WXH62yMEO7SvpuOCHrM8mQ-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-763af8e4624so73944885a.0 for ; Thu, 22 Jun 2023 14:21:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687468906; x=1690060906; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F0mx9jrxaCUPAUyvvuyEyQm8iB06V46NLUYE7mR/4q4=; b=DGWR7P7awbeFTTRRxhain/WUHS2GGCKXlWrFOxgmRHlpO7/OtoGztdZQRa7blPg4V2 CtojGsRZcK5yJDi5Qkcpdy5opANyvuJ93fIFRVwEKX4VUZvlc4i0J1WtakNIYhGGv5wy 7pLHFNOqaNtqHQVIKCGLeH4nG7DJJIsYvG5/wQNF0FPZy2Ti17B0UlNeWKX3wmkxLi7S 09jAhVR/03mkBOAj49HcJ9X7TL6aq08LRDvAUnVo5mEMqjhPJtRnz54+gnWsELWOGATT xMEX6iS+95tW5mNLb0I/NYvcfxcIxHOf2Tl0jK/f+kmbc7DdtlO1KqVjNX2RYiBmdzxO cPyA== X-Gm-Message-State: AC+VfDyNbusjUnOE4r5Tmdm+0QxB3sTumfVueqQ+GyE0eQrhV5Ea+f3y BpaRYO2lqBGfWISQ2Eh9Wv+uFm0LK8MD0PxG/3v6T7LtIsIgmXybA+Nh7mwOWra7w/bFumGepeN 32rWLycVj9iCy X-Received: by 2002:a05:620a:628e:b0:763:aa22:9f41 with SMTP id ov14-20020a05620a628e00b00763aa229f41mr9865822qkn.3.1687468906289; Thu, 22 Jun 2023 14:21:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ53T+hoRlHPI3gLbhnr1ctZtCkNlIP6LMLXwWrpxvXjj4UPOZphI2cy+KUE2nXGfomY2JFY/A== X-Received: by 2002:a05:620a:628e:b0:763:aa22:9f41 with SMTP id ov14-20020a05620a628e00b00763aa229f41mr9865812qkn.3.1687468906044; Thu, 22 Jun 2023 14:21:46 -0700 (PDT) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id h16-20020ae9ec10000000b007607ecd58ecsm1091001qkg.59.2023.06.22.14.21.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jun 2023 14:21:45 -0700 (PDT) Message-ID: <734eef7c-f7c3-519c-e007-cb42f8dc8a82@redhat.com> Date: Thu, 22 Jun 2023 17:21:42 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v5 4/5] c++modules: report imported CMI files as dependencies To: Ben Boeckel , gcc-patches@gcc.gnu.org Cc: nathan@acm.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org, brad.king@kitware.com References: <20230125210636.2960049-1-ben.boeckel@kitware.com> <20230125210636.2960049-5-ben.boeckel@kitware.com> From: Jason Merrill In-Reply-To: <20230125210636.2960049-5-ben.boeckel@kitware.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/25/23 16:06, Ben Boeckel wrote: > They affect the build, so report them via `-MF` mechanisms. Why isn't this covered by the existing code in preprocessed_module? > gcc/cp/ > > * module.cc (do_import): Report imported CMI files as > dependencies. > > Signed-off-by: Ben Boeckel > --- > gcc/cp/module.cc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/cp/module.cc b/gcc/cp/module.cc > index ebd30f63d81..dbd1b721616 100644 > --- a/gcc/cp/module.cc > +++ b/gcc/cp/module.cc > @@ -18966,6 +18966,8 @@ module_state::do_import (cpp_reader *reader, bool outermost) > dump () && dump ("CMI is %s", file); > if (note_module_cmi_yes || inform_cmi_p) > inform (loc, "reading CMI %qs", file); > + /* Add the CMI file to the dependency tracking. */ > + deps_add_dep (cpp_get_deps (reader), file); > fd = open (file, O_RDONLY | O_CLOEXEC | O_BINARY); > e = errno; > }