From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id C6D5B3858D20; Tue, 8 Mar 2022 23:34:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C6D5B3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,165,1643702400"; d="scan'208";a="72733170" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 08 Mar 2022 15:34:54 -0800 IronPort-SDR: hOkP29ZgWts5ARcZE1mi0+TZemirSuvGPDIgja33PjxY30WoJKk/QaZ9BcSAg+ufJlvR0IX6uq Vc5Fkq8wa2/9MrGtJhrlgblduw4L5ndhfV4xvlPnDPDOaF3DGk6tAv6jCJcwhpvOtuGmT+Z+Fp KioRSylfLvx53m4YgI0Cu6JiDCkjTCO3ewa2p+kbAoaJIOOB0lk6HDqqAu+H84Yd5bC/coZdNH yckYBmHTB+AmRmQDUv0NaBXu/rm+Er/fVl7tK1CIP0PllZaY5eDXWv1iqSH5Xv+F3e9uN2dbkj aQc= Message-ID: <742743fe-d2ab-9cc5-8d94-2585cdd262f3@codesourcery.com> Date: Wed, 9 Mar 2022 00:34:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [Patch] Fortran: Fix gfc_conv_gfc_desc_to_cfi_desc with NULL [PR104126] Content-Language: en-US To: Harald Anlauf , gcc-patches , fortran References: <5535ea6a-80d1-c674-fa5b-a28ec26c2ce0@codesourcery.com> From: Tobias Burnus In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2022 23:34:56 -0000 Hi Harald, On 08.03.22 22:44, Harald Anlauf wrote: > Am 07.03.22 um 15:16 schrieb Tobias Burnus: >> Pre-remark: Related NULL, there some accepts-invalid issues, not >> addressed in this >> patch. See https://gcc.gnu.org/PR104819 >> >> This patch fixes an ICE (12 regression) with NULL() that has no MOLD >> argument. > the patch does fix the ICE. But given your short pre-remark: > are you saying that the testcase is invalid, and with the patch > we silently accept it now? Sorry for being confusing. I also believe the testcase of the just committed patch is valid Fortran. However, when fixing this PR, I was looking at the spec =E2=80=93 and saw t= hat GCC accepts invalid code using NULL(), which is not diagnosed. Those issues are orthogonal to this patch, except that the accepts-invalid issues also are about NULL(). Thanks for the review! Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955