From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id 17B143858C5E for ; Fri, 10 Mar 2023 03:56:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17B143858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1034.google.com with SMTP id kb15so4147950pjb.1 for ; Thu, 09 Mar 2023 19:56:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678420590; h=content-transfer-encoding:in-reply-to:subject:from:content-language :references:cc:to:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=+x7i8sVJB5b5P0HZHm2O9CoPb8BKSx3eZXRVo9xnXH8=; b=kGeAGHLYWdQRUekE6n+/bCcVWsTuIWty4qsA6voLdFQylGuyv/lCGledaz/wYZ0YM2 uz2NoioJZdhUoJcVBQV6eqm8p6fBF76RW0HAWf8g98IpES358i74S9EBZxrmfPp+QVZp woNctMkHi0eSfpsaBRCHpkbbJSN1FJYOFPtl1miA67io/WnD9Y0qcAREgAokj5LDwuKK WR3aStiJePkI19bJ8GXh+13I33VGkDD2Xa8yZ0ZuXFe3/dAkVq3dGfM58RjM0BbJ1iZC GsEsLQyA9gYOLRhh2jBgxszycL08yN9K8N0o0JYwl+ZoImHa+iYK6Z+wMx9ik6+4Jfnq qIOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678420590; h=content-transfer-encoding:in-reply-to:subject:from:content-language :references:cc:to:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+x7i8sVJB5b5P0HZHm2O9CoPb8BKSx3eZXRVo9xnXH8=; b=oBJ/M6SGtdffkj8+yZ9ITCjd9IOUgVgI5qxmjT/yz4M2WXk3nT+qc929Q3nhxP88ve JwvuBAUjsGYOo+WOxUA7qgRiIL/ATervHCHvSbwRvqJKQc1JF+Bx6hq9xCCWjEM0X5FF 80DkbpBntAw2OxAfnoF4/5H47lNhSN1thenqYVTA/kJdoCVN5vCCEf9zf/TQIGnfDxuM PcseQ+MeeVy+QOOKHSYqZ2eSsJ2/pDRIL0VgZJhb0diouCT3pREAsl+HFgGrHUcYC8h5 MsNoRdf3mnF4b2+K+Aj1MXOZF3L/XnCp8uMgZfF6H6n9TI2e0xnAu5A01yxtRJFrfz/B swZg== X-Gm-Message-State: AO0yUKXScbGCNN8XAZJSxaXnFbHDW/js5leaJ5CEzAl3Pv69GPfmPOAd 2QuRZhq52DQyRJjTT+w49Mo= X-Google-Smtp-Source: AK7set/Xb2pi3ppQGbscmF5vOp/9gJxyvA3XTeegBFqDZNlLpRgX4k1kS3jXLLy+Q5/i7p+7b448/Q== X-Received: by 2002:a17:90a:2ec4:b0:233:dd4d:6b1a with SMTP id h4-20020a17090a2ec400b00233dd4d6b1amr1230097pjs.3.1678420590007; Thu, 09 Mar 2023 19:56:30 -0800 (PST) Received: from [192.168.1.20] ([50.37.188.226]) by smtp.gmail.com with ESMTPSA id n2-20020a17090ac68200b00219752c8ea5sm331101pjt.37.2023.03.09.19.56.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Mar 2023 19:56:29 -0800 (PST) Message-ID: <7735080a-beca-a0e1-a678-23ba69b1ea7d@gmail.com> Date: Thu, 9 Mar 2023 19:56:28 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: Thomas Koenig , Paul Richard Thomas , Richard Biener Cc: Steve Kargl , "fortran@gcc.gnu.org" References: <582085ac-0d07-a516-732d-e82e0a4e01c9@netcologne.de> Content-Language: en-US From: Jerry D Subject: Re: [Patch, fortran] PR37336 finalization In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: While recovering from an illness here folks I have been following all of these discussions. I think I will put in my two cents worth. From what i can see, Paul's patch breaks nothing and fixes many things. The only thing holding us back is fear we might break something. The likelihood of actually breaking something is very low. The consequences of breaking anything, worst case, is to revert a patch. (ie no consequence) It is clear to me the value added clearly exceeds the the risks by a lot. Therefore, as Spock would say, it is illogical to not make a decision and move forward with this finalization patch, and commit it. More will be advanced from making this decision from not making this decision. Regards, Jerry On 3/9/23 9:30 AM, Thomas Koenig via Fortran wrote: > Hi Paul, > > >> -fdefault-integer-8 does indeed fix the problem with rnflow.f90 but >> breaks tfft2.f90, with a type mismatch at lines 36 and 44. >> >>        integer(8), parameter   :: jmul =  843314861  ! multiplicateur >>        integer(8), parameter   :: jadd =  453816693  ! constante additive >> Does the job and is portable. >> > > I think -frwapv (as suggested by Jakub) would be the better choice. > The problem is the linear congruential pseudo-random number generators > which were much used in earlier times (and are still present in > legacy code), which violate the Fortran standards by assuming silent > truncation. > > If a new optimization breaks this (widespread, but illegal) idiom, > maybe the best way to deal with it is to add -frwapv to -std=legacy. > > What do you think? > > Best regards > >     Thomas