From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) by sourceware.org (Postfix) with ESMTPS id 337C93858D38; Mon, 26 Dec 2022 22:26:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 337C93858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=protonmail.com Date: Mon, 26 Dec 2022 22:26:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1672093593; x=1672352793; bh=anvBVXGPb4MzY3jmokaoVRklvByYq/hSGxEM1r+SnSo=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=Vmb4ITfnUW+8QwMj8sFy1EXOk6En4P3w9osJWFgg1erzqRPxIRxjnX2NE580bcUJ7 wceiIk4XzJh3m7W/6/t4lfEU8/GtAKTxkM6EHqGO9a46tHnCBWzlkOhaO+pSKkAtEg D5xEcF9dFoivbirxVXOeAbI99EJpHKoA00RsajgTXq2Qibb4/kqtsudwPrF+WWzdmH PYSTplAAJKd+4I2lAN6Tv8RZSxhMFibgVebMNHXz6VkFoiaByFmPtJHiRh4KfIAuoy LRe6nvqnwdTdGVR4smqdESO6DHnPME+1hYtaSexU10o5gp9lnrOzeiTac3G578IODZ 4II8dEet+Tmlg== To: gfortran From: Jerry DeLisle Cc: gcc-patches Subject: [patch, fortran] ICE in attr_decl1, at fortran/decl.c:8691 Message-ID: <7802b3ba-cf1d-84eb-6e64-e470ef8e911a@protonmail.com> Feedback-ID: 34907122:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_gy8rZyibyn51RTW4rxtCoUaIwv2n2DkNkTryABO7Gk" X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --b1_gy8rZyibyn51RTW4rxtCoUaIwv2n2DkNkTryABO7Gk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable The attached patch was provided by Steve Kargl. After exploring for possible other checks I settled on leaving the patch intact. Two existing test cases updated as different but sensible error messages resulted. Regression tested on main line. OK to commit? Regards, Jerry Author: Steve Kargl Date: Mon Dec 26 14:07:04 2022 -0800 Modify checks to avoid referencing NULL pointer. Update test cases with error messages that changed as a result. gcc/fortran/ChangeLog: * decl.cc (attr_decl1): Guard against NULL pointer. * parse.cc (match_deferred_characteristics): Include BT_CLASS in check for derived being undefined. gcc/testsuite/ChangeLog: * gfortran.dg/class_result_4.f90: Update error message check. * gfortran.dg/pr85779_3.f90: Update error message check. --b1_gy8rZyibyn51RTW4rxtCoUaIwv2n2DkNkTryABO7Gk Content-Type: text/x-patch; name=pr102331.diff Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=pr102331.diff ZGlmZiAtLWdpdCBhL2djYy9mb3J0cmFuL2RlY2wuY2MgYi9nY2MvZm9ydHJhbi9kZWNsLmNjCmlu ZGV4IGU1OTM1MThhNzdlLi5iYWM3YjY1NjhiMCAxMDA2NDQKLS0tIGEvZ2NjL2ZvcnRyYW4vZGVj bC5jYworKysgYi9nY2MvZm9ydHJhbi9kZWNsLmNjCkBAIC04NzQzLDcgKzg3NDMsOSBAQCBhdHRy X2RlY2wxICh2b2lkKQogICAvKiBVcGRhdGUgc3ltYm9sIHRhYmxlLiAgRElNRU5TSU9OIGF0dHJp YnV0ZSBpcyBzZXQgaW4KICAgICAgZ2ZjX3NldF9hcnJheV9zcGVjKCkuICBGb3IgQ0xBU1MgdmFy aWFibGVzLCB0aGlzIG11c3QgYmUgYXBwbGllZAogICAgICB0byB0aGUgZmlyc3QgY29tcG9uZW50 LCBvciAnX2RhdGEnIGZpZWxkLiAgKi8KLSAgaWYgKHN5bS0+dHMudHlwZSA9PSBCVF9DTEFTUyAm JiBzeW0tPnRzLnUuZGVyaXZlZC0+YXR0ci5pc19jbGFzcykKKyAgaWYgKHN5bS0+dHMudHlwZSA9 PSBCVF9DTEFTUworICAgICAgJiYgc3ltLT50cy51LmRlcml2ZWQKKyAgICAgICYmIHN5bS0+dHMu dS5kZXJpdmVkLT5hdHRyLmlzX2NsYXNzKQogICAgIHsKICAgICAgIC8qIGdmY19zZXRfYXJyYXlf c3BlYyBzZXRzIHN5bS0+YXR0ciBub3QgQ0xBU1NfREFUQShzeW0pLT5hdHRyLiAgQ2hlY2sKIAkg Zm9yIGR1cGxpY2F0ZSBhdHRyaWJ1dGUgaGVyZS4gICovCmRpZmYgLS1naXQgYS9nY2MvZm9ydHJh bi9wYXJzZS5jYyBiL2djYy9mb3J0cmFuL3BhcnNlLmNjCmluZGV4IGJjMmIyMTg4ZWVhLi42MTg2 YzQ4YWVlMiAxMDA2NDQKLS0tIGEvZ2NjL2ZvcnRyYW4vcGFyc2UuY2MKKysrIGIvZ2NjL2ZvcnRy YW4vcGFyc2UuY2MKQEAgLTM5MzQsNyArMzkzNCw3IEBAIG1hdGNoX2RlZmVycmVkX2NoYXJhY3Rl cmlzdGljcyAoZ2ZjX3R5cGVzcGVjICogdHMpCiAgIG0gPSBnZmNfbWF0Y2hfcHJlZml4ICh0cyk7 CiAgIGdmY19idWZmZXJfZXJyb3IgKGZhbHNlKTsKIAotICBpZiAodHMtPnR5cGUgPT0gQlRfREVS SVZFRCkKKyAgaWYgKHRzLT50eXBlID09IEJUX0RFUklWRUQgfHwgdHMtPnR5cGUgPT0gQlRfQ0xB U1MpCiAgICAgewogICAgICAgdHMtPmtpbmQgPSAwOwogCkBAIC00MjE1LDcgKzQyMTUsNyBAQCBk ZWNsU3Q6CiAgIGlmIChiYWRfY2hhcmFjdGVyaXN0aWMpCiAgICAgewogICAgICAgdHMgPSAmZ2Zj X2N1cnJlbnRfYmxvY2sgKCktPnJlc3VsdC0+dHM7Ci0gICAgICBpZiAodHMtPnR5cGUgIT0gQlRf REVSSVZFRCkKKyAgICAgIGlmICh0cy0+dHlwZSAhPSBCVF9ERVJJVkVEICYmIHRzLT50eXBlICE9 IEJUX0NMQVNTKQogCWdmY19lcnJvciAoIkJhZCBraW5kIGV4cHJlc3Npb24gZm9yIGZ1bmN0aW9u ICVxcyBhdCAlTCIsCiAJCSAgIGdmY19jdXJyZW50X2Jsb2NrICgpLT5uYW1lLAogCQkgICAmZ2Zj X2N1cnJlbnRfYmxvY2sgKCktPmRlY2xhcmVkX2F0KTsKZGlmZiAtLWdpdCBhL2djYy90ZXN0c3Vp dGUvZ2ZvcnRyYW4uZGcvY2xhc3NfcmVzdWx0XzQuZjkwIGIvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJh bi5kZy9jbGFzc19yZXN1bHRfNC5mOTAKaW5kZXggNGIyMmEzYzMwZWUuLjU0OTdhYzY1MmVjIDEw MDY0NAotLS0gYS9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL2NsYXNzX3Jlc3VsdF80LmY5MAor KysgYi9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL2NsYXNzX3Jlc3VsdF80LmY5MApAQCAtMSw2 ICsxLDYgQEAKICEgeyBkZy1kbyBjb21waWxlIH0KICEgUFIgZm9ydHJhbi83ODUwMAotY2xhc3Mo dCkgZnVuY3Rpb24gZigpICEgeyBkZy1lcnJvciAibXVzdCBiZSBkdW1teSwgYWxsb2NhdGFibGUg b3IgcG9pbnRlciIgfQorY2xhc3ModCkgZnVuY3Rpb24gZigpICEgeyBkZy1lcnJvciAiaXMgbm90 IGFjY2Vzc2libGUiIH0KICAgIGYgPSAxICAgICAgICAgICAgICAhIHsgZGctZXJyb3IgInZhcmlh YmxlIG11c3Qgbm90IGJlIHBvbHltb3JwaGljIiB9CiBlbmQKIApkaWZmIC0tZ2l0IGEvZ2NjL3Rl c3RzdWl0ZS9nZm9ydHJhbi5kZy9wcjg1Nzc5XzMuZjkwIGIvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJh bi5kZy9wcjg1Nzc5XzMuZjkwCmluZGV4IGZiYTExMzNiM2VhLi5hODFhOWZhZjg4ZSAxMDA2NDQK LS0tIGEvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9wcjg1Nzc5XzMuZjkwCisrKyBiL2djYy90 ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvcHI4NTc3OV8zLmY5MApAQCAtMSw2ICsxLDYgQEAKICEgeyBk Zy1kbyBjb21waWxlIH0KICEgUFIgZm9ydHJhbi84NTc3OQotY2xhc3ModCkgZnVuY3Rpb24gZigp ICAgISB7IGRnLWVycm9yICJtdXN0IGJlIGR1bW15LCBhbGxvY2F0YWJsZSBvciBwb2ludGVyIiB9 CitjbGFzcyh0KSBmdW5jdGlvbiBmKCkgICAhIHsgZGctZXJyb3IgImlzIG5vdCBhY2Nlc3NpYmxl IiB9CiAgICB0eXBlIGYgICAgICAgICAgICAgICAhIHsgZGctZXJyb3IgImFscmVhZHkgaGFzIGEg YmFzaWMgdHlwZSIgfQogICAgZW5kIHR5cGUgICAgICAgICAgICAgISB7IGRnLWVycm9yICJFTkQg RlVOQ1RJT04gc3RhdGVtZW50IiB9CiBlbmQK --b1_gy8rZyibyn51RTW4rxtCoUaIwv2n2DkNkTryABO7Gk--