From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id D495338432DD; Sun, 4 Dec 2022 20:05:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D495338432DD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1670184299; bh=0u0xgEYXVULIzgzOtspbwXvuzvowgLsk1Z+oCX80NJE=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=IwS/DWyORCBWhTALIaLrxFlVmqzI4l7xPSFRJStayTQjWt2xxr1i6ChjCCCDt8f/8 W+LTBsDUphFW8phYgAW6GhSwoYqEyWlExEU8uh8mzK5nb3kGHOaH2CbihAr5OPY5eM LUUadhhxt74d5fRsBUOdDlrABlHPaf/V14g3RoSRfX+dG90RCRkPYme1dywy3fAaGU 1oJfRR0E2BBwvAoeEu2A2CVPqm38u1NWLE1pN+Qheo7CkuWYGXy67NHSet9SRQ4lFX ERKI0tRhW8H+xyUqHxWIgylS1Lm2Do1/OjUm1jy/rF0AAPaAqj2yo4O85uYqcbfclT gZkyijlQKq1Jg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.89.181]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MDywo-1p9aCF00sG-009uvW; Sun, 04 Dec 2022 21:04:59 +0100 Message-ID: <7968b07a-6453-d592-c5a0-bb28699dab01@gmx.de> Date: Sun, 4 Dec 2022 21:04:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] Fortran: error recovery simplifying UNPACK for insufficient FIELD [PR107922] Content-Language: en-US To: Mikael Morin , fortran , gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <428cdc11-84c7-3837-e96f-9ec00c640643@orange.fr> From: Harald Anlauf In-Reply-To: <428cdc11-84c7-3837-e96f-9ec00c640643@orange.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ixQVBVLO3F8dJcQ/y/PY0ho/YSIDNfR1s+fCA6YvedxsI0VsM3m GuFuFKBFInizFoppHDz3A7p6tI1vrKDMJKK0g9Y/6dMsGNcXgeBFx1EumVcRBN2mJ0qm/6/ 1T73+YYqQ8So7MS1fFTipUC/GUChLiVP3okmHaH3KehDBMbuZiU5FbFl27AfwD1tlPUZxZI zqtHTVo6TtPMre2m0deaA== UI-OutboundReport: notjunk:1;M01:P0:I7EsSRIkIBc=;LqZKvRuUgBFPlz3NbDg+lWK6Kvj HOngl/zLC0f1Qb/Vb4L3jiZszXEX0nbucAlgf8okQh5j2Lkw995LhWVRVgh5Wphh9Pv3N3E5y 1QlP4LZ5E3eGVJytzmIhD6kJq8r9ThooFIZ5aMJp/+9OqDVmXkwqjYuKtRfFrT9ShFGg1EGmi 1mnC1Fjfd1FkHXyQU2Sb9yXzmLy9i9q5ZraNVEXYfgoC5U9ZYGx5xaGhZ/6+oqAXPAaCUAWI/ R4+tv9r5SqQbuwOr/2h3W3Asf0C5g97tYV3+2ML2MZT9CpIJ+Qpx4oMoj1gZuRvqirB2Z6p/E tUrQG9rvdCtokG3OVRTkDENEvKsxyaijpQXbCqhCMyhU+hSwDorDS8JfHJ+rx0tIzdObuyLPc I4bRHU03pXcXcsxzNCcl7htt0xE2cy5EustBqtuQUaPi1W/LNg4OYMr5FD+SKTP9z/wr47NW7 zPI6QzWvQlm1Jnco4kZSWNUWkRRHv6fLf6uM2UMlYfPd2Fqf1cDkBFsfHtf4kxI4/ItZpGRAc T9nuD9DQkBhUy25/WHZfLXu5P7AT4vJui9U6TSLWlAiHPoT6BSuxyB0WUandJPVg+EpEDs3Yz 3CVWvk8C11c050CDZq/QclyRH46wXjVbwFq1Kb391ImF9e5cHNjyRpkesV+ThK4H2g3fDFsIU 5h7Dk6wet7tvHQbQ+e1aQANpRaXnDNHJAPfVn44m4c4CVlQ7FI9A31PF51fnM1jgfKnoY3ktN ajC4Ljx6RgSR5Rj+truvzFr/Es1uUy6PVtXXTnwShRJIExjbLhcDN60tQU4p7Hxue7DOWJYOX etQFNBLLS3j8Ao0XADXT2KmTS8wwVCdMiPdgu+/XPtHKJGwSUXw9KwWDr8SsBa90prqMkJk8m nb0QafCNEX+WkDjCxIiOJsunBmI+Lz6goiqvyqVVjDMOPteD8wlJiFkeOaSaIO3l4M6zMEuPU XZDtNIjJTa8c/F/g2YMAOoS0+w4= X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Mikael, Am 04.12.22 um 14:11 schrieb Mikael Morin: > Le 01/12/2022 =C3=A0 21:25, Harald Anlauf via Fortran a =C3=A9crit=C2=A0= : >> Dear all, >> >> we did not properly handle the case of insufficient array-valued >> FIELD when trying to simplify UNPACK and could run into a NULL >> pointer dereference.=C2=A0 The fix is obvious. >> >> Regtested on x86_64-pc-linux-gnu.=C2=A0 OK for mainline? >> > The change looks good, but please add braces around the new if-else > structure. > OK with that change. thanks for the hint. It indeed looks more readable with this small change= . Pushed: r13-4486-g24b9337d1f1b5197b6498dceb9074319be003449 > Thanks. > Thanks, Harald