From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53417 invoked by alias); 10 Nov 2015 15:39:14 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 53367 invoked by uid 89); 10 Nov 2015 15:39:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: nef2.ens.fr Received: from nef2.ens.fr (HELO nef2.ens.fr) (129.199.96.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Nov 2015 15:39:13 +0000 Received: from mailhost.lps.ens.fr (tournesol.lps.ens.fr [129.199.120.1]) by nef2.ens.fr (8.13.6/1.01.28121999) with ESMTP id tAAFd9ph005301 ; Tue, 10 Nov 2015 16:39:09 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mailhost.lps.ens.fr (Postfix) with ESMTP id 9B398186; Tue, 10 Nov 2015 16:39:09 +0100 (CET) Received: from mailhost.lps.ens.fr ([127.0.0.1]) by localhost (tournesol.lps.ens.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YD0hryiAOYPf; Tue, 10 Nov 2015 16:39:09 +0100 (CET) Received: from [192.168.1.14] (log78-1-82-242-47-10.fbx.proxad.net [82.242.47.10]) by mailhost.lps.ens.fr (Postfix) with ESMTPSA id E779517D; Tue, 10 Nov 2015 16:39:08 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: [Patch, fortran] Bug 68241 - [meta-bug] Deferred-length character - PRs50221, 68216 and 67674 From: =?utf-8?Q?Dominique_d=27Humi=C3=A8res?= In-Reply-To: Date: Tue, 10 Nov 2015 15:39:00 -0000 Cc: Steve Kargl , "fortran@gcc.gnu.org" , Damian Rouson , Louis Krupp Content-Transfer-Encoding: quoted-printable Message-Id: <7D748E43-39F5-49DC-BD80-C2A1301165EE@lps.ens.fr> References: <20151109144654.GA44618@troutmask.apl.washington.edu> To: Paul Richard Thomas X-SW-Source: 2015-11/txt/msg00048.txt.bz2 Dear Paul, The patch for gcc/fortran/trans-types.c does not apply on revision r230071 = and I had to use --- ../_clean/gcc/fortran/trans-types.c 2015-11-08 18:04:13.000000000 +0100 +++ gcc/fortran/trans-types.c 2015-11-10 11:57:33.000000000 +0100 @@ -1455,7 +1455,13 @@ gfc_get_dtype_rank_type (int rank, tree=20 } =20 gcc_assert (rank <=3D GFC_DTYPE_RANK_MASK); - size =3D TYPE_SIZE_UNIT (etype); +=20 + if (TREE_CODE (etype) =3D=3D ARRAY_TYPE + && TYPE_MAXVAL (TYPE_DOMAIN (etype)) !=3D NULL_TREE + && TREE_CODE (TYPE_MAXVAL (TYPE_DOMAIN (etype))) =3D=3D VAR_DECL) + size =3D TYPE_MAXVAL (TYPE_DOMAIN (etype)); + else + size =3D TYPE_SIZE_UNIT (etype); =20 i =3D rank | (n << GFC_DTYPE_TYPE_SHIFT); if (size && INTEGER_CST_P (size)) which I hope is correct. With the patch (and a few others!-) I have regstrapped without any regressi= on. The tests in pr50221 are fixed except the one in comment 4, the output = is 4 4 A=20=20=20 CDV=20 ? I have also found that pr63932 and pr66408 are fixed by the patch. Thanks for your work on this issue, Dominique > Le 10 nov. 2015 =C3=A0 10:48, Paul Richard Thomas a =C3=A9crit : >=20 > Dear Steve, >=20 > I was charging around like a mad thing yesterday and sent the > submission in something of a hurry. Thanks for pointing out the > omission so quickly. >=20 > Please find the patch attached. >=20 > Cheers >=20 > Paul >=20