From: Cesar Philippidis <cesar@codesourcery.com>
To: Thomas Koenig <tkoenig@netcologne.de>,
Fortran List <fortran@gcc.gnu.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [patch,wip] warn on noncontiguous pointers
Date: Wed, 26 Sep 2018 20:55:00 -0000 [thread overview]
Message-ID: <7f9badf1-96b0-ce00-6b67-e2d99d085725@codesourcery.com> (raw)
In-Reply-To: <beba6227-a4ac-4237-e7cc-9f47f134f077@netcologne.de>
On 09/26/2018 01:49 PM, Thomas Koenig wrote:
> Hi Cesar,
>
>> As of GCC 8, gfortran now errors when a pointer with a contiguous
>> attribute is set to point to a target without a contiguous attribute. I
>> think this is overly strict, and should probably be demoted to a
>> pedantic warning as I've done in the attached patch.
>
> We had a lengthy discussion on that one. Still, we can dig into the
> standard for that one.
>
> J3/10-007 says in 7.2.2.3Â Data pointer assignment
>
> # 7 If the pointer object has the CONTIGUOUS attribute, the pointer
> # target shall be contiguous.
>
> # 9 If bounds-remapping-list is specified, the pointer target shall
> # be simply contiguous (6.5.4) or of rank one
>
> program test
> Â Â implicit none
> Â Â real,pointer :: fptr1(:)
> Â Â real,pointer,contiguous :: fptr3(:,:,:)
>
> Â Â allocate(fptr1(12))
> Â Â call random_number(fptr1)
>
> Â Â !Test pointer reshape II
>
> Â Â fptr3(1:2,1:2,1:2) => fptr1(4:)
>
> end program
>
> So, by paragraph 9, this would be OK. Let's see what paragraph 7
> means when it says "contiguous". 5.3.7 says
>
> An object is contiguous if it is
>
> # (1) an object with the CONTIGUOUS attribute,
> # (2) a nonpointer whole array that is not assumed-shape,
> # (3) an assumed-shape array that is argument associated with an
> Â Â Â Â array that is contiguous,
> # (4) an array allocated by an ALLOCATE statement,
> # (5) a pointer associated with a contiguous target, or
> # (6) a nonzero-sized array section (6.5.3) provided that
> #Â Â (a) its base object is contiguous,
> #Â Â (b) it does not have a vector subscript,
> #Â Â (c) the elements of the section, in array element order, are a
> #Â Â Â Â Â Â subset of the base object elements that are consecutive in
> #Â Â Â Â Â Â array element order,
> #Â Â (d) if the array is of type character and a substring-range appears,
> #Â Â Â Â Â Â the substring-range specifies all of the characters of the
> #Â Â Â Â Â Â parent string (6.4.1),
> #Â Â (e) only its final part-ref has nonzero rank, and
> #Â Â (f) it is not the real or imaginary part (6.4.4) of an array of type
> #Â Â Â Â Â Â complex.
>
> An object is not contiguous if it is an array subobject, and
>
> [conditions not relevant elided]
>
> # It is processor dependent whether any other object is contiguous.
>
> If we go down the list, we see that fptr1(4:) is not contiguous; it
> is not an array (it is a pointer), so (4) also does not apply.
>
> So, we are in the realm of processor dependent behavior, so we can
> chose what to do.
>
> The last time we discussed this, we agreed on a hard error. One
> important argument is that a mistakenly applied contiguous
> attribute will lead to wrong code, and that it is quite easy
> to check this, as we do now.
>
> So, I think we should leave the behavior as it is now, and
Thank you for the explanation. That all seems reasonable.
>> Maybe the ScaTeLib code needs to be updated.
>
> sounds like a good idea to me.
ACK.
Thanks,
Cesar
next prev parent reply other threads:[~2018-09-26 20:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 18:51 Cesar Philippidis
2018-09-26 20:49 ` Thomas Koenig
2018-09-26 20:55 ` Cesar Philippidis [this message]
2018-09-27 8:00 Bader, Reinhold
2018-09-27 17:23 ` Thomas Koenig
2018-09-28 5:12 ` AW: " Bader, Reinhold
2018-09-30 18:12 ` Thomas Koenig
2018-10-01 13:36 ` Cesar Philippidis
2018-10-03 21:16 ` Cesar Philippidis
2018-10-05 6:14 ` Thomas Koenig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f9badf1-96b0-ce00-6b67-e2d99d085725@codesourcery.com \
--to=cesar@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).