From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Harald Anlauf <anlauf@gmx.de>
Cc: Harald Anlauf via Gcc-patches <gcc-patches@gcc.gnu.org>,
fortran <fortran@gcc.gnu.org>
Subject: Re: [PATCH] PR fortran/100950 - ICE in output_constructor_regular_field, at varasm.c:5514
Date: Fri, 11 Jun 2021 08:02:33 +0200 [thread overview]
Message-ID: <80A07CBC-4E65-4078-B432-1CF93CF8084D@gmail.com> (raw)
In-Reply-To: <trinity-58c46611-3a76-4e85-93ab-314d0041369f-1623351132345@3c-app-gmx-bap45>
On 10 June 2021 20:52:12 CEST, Harald Anlauf <anlauf@gmx.de> wrote:
>> I think the mpz_set_si args above fit on one line.
>
>That's true.
>
>Since this block is exactly the same as for constant strings,
>which is handled in the first condition, I've thought some more
>and am convinced now that these two can be fused. Done now.
Thanks.
Btw.. I know that we cast hwi to long int often and use %ld but think there is a HOST_WIDE_INT_PRINT_DEC format macro to print a hwi.
>I've also added two cornercases to the testcase, and regtested again.
>
>> btw.. there's a commentary typo in add_init_expr_to_sym():
>> s/skeep/skip/
>
>That is a completely unrelated issue in a different file, right?
Completely unrelated, yes.
>
>Thanks for your constructive comments!
thanks for the patch!
next prev parent reply other threads:[~2021-06-11 6:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 21:39 Harald Anlauf
2021-06-10 10:24 ` Bernhard Reutner-Fischer
2021-06-10 12:47 ` Bernhard Reutner-Fischer
2021-06-10 18:52 ` Harald Anlauf
2021-06-11 6:02 ` Bernhard Reutner-Fischer [this message]
2021-06-21 12:12 ` Tobias Burnus
2021-07-12 21:23 ` Harald Anlauf
2021-08-03 21:17 ` Harald Anlauf
2021-08-11 19:28 ` *PING* " Harald Anlauf
2021-08-18 10:22 ` Tobias Burnus
2021-08-18 21:01 ` Harald Anlauf
2021-08-19 7:52 ` Tobias Burnus
2021-08-19 19:11 ` Harald Anlauf
2021-08-20 0:21 ` H.J. Lu
2021-08-20 6:48 ` Harald Anlauf
2021-08-20 9:16 ` Jakub Jelinek
2021-08-20 9:45 ` Aw: " Harald Anlauf
2021-08-20 10:12 ` Jakub Jelinek
2021-08-20 10:53 ` Aw: " Harald Anlauf
2021-08-20 10:59 ` Jakub Jelinek
2021-08-20 11:43 ` [PATCH, committed] Fix bootstrap breakage caused by r12-3033 (PR fortran/100950 - ICE in output_constructor_regular_field, at varasm.c:5514) Harald Anlauf
2021-08-20 12:01 ` Aw: Re: Re: [PATCH] PR fortran/100950 - ICE in output_constructor_regular_field, at varasm.c:5514 Tobias Burnus
2021-08-20 12:17 ` Aw: " Harald Anlauf
2021-08-20 14:19 ` Tobias Burnus
2021-08-20 19:43 ` Harald Anlauf
2021-08-20 11:50 ` [Patch] c-format.c/Fortran: Support %wd / host-wide integer in gfc_error (Re: [PATCH] PR fortran/100950 - ICE in output_constructor_regular_field, at varasm.c:5514) Tobias Burnus
2021-08-20 11:56 ` Jakub Jelinek
2021-08-20 13:47 ` Tobias Burnus
2021-08-20 13:53 ` Jakub Jelinek
2021-08-20 9:29 ` [PATCH] PR fortran/100950 - ICE in output_constructor_regular_field, at varasm.c:5514 Tobias Burnus
2021-06-18 20:47 ` PING " Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80A07CBC-4E65-4078-B432-1CF93CF8084D@gmail.com \
--to=rep.dot.nop@gmail.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).