public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: FX <fxcoudert@gmail.com>
To: FX via Fortran <fortran@gcc.gnu.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fortran: Add IEEE_SIGNBIT and IEEE_FMA functions
Date: Tue, 6 Sep 2022 15:26:05 +0200	[thread overview]
Message-ID: <80F2E884-677E-4761-875A-082D853F913B@gmail.com> (raw)
In-Reply-To: <7A9A82FB-3144-406C-A4E5-87F8EAC72044@gmail.com>

ping on that patch from last week

Maybe the ping is a bit early, as you know I’m not very active anymore, so I do not know what are the current policies. In particular, how much leeway do I have to commit the patch if there is no comment from another maintainer?

I am fairly confident about the code, because I wrote the original IEEE implementation so I know it very well. I believe it would probably be better to commit this and have it tested on mainline, that wait for too long. I intend to submit further patches and improvements in this area, once those are merged.

Best,
FX



> Le 31 août 2022 à 16:22, FX <fxcoudert@gmail.com> a écrit :
> 
> Hum, slightly amended patch, after checking 32-bit results on another linux machine.
> The test for FMA has been made a bit less strict, because otherwise we have surprised on 387 arithmetic due to excess precision.
> 
> Final patch is attached. Regression-tested on x86_64-pc-linux-gnu, both 32- and 64-bit.
> OK to commit?
> 
> FX
> 
> <0001-fortran-Add-IEEE_SIGNBIT-and-IEEE_FMA-functions.patch>


  reply	other threads:[~2022-09-06 13:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-31 13:46 FX
2022-08-31 14:22 ` FX
2022-09-06 13:26   ` FX [this message]
2022-09-07  5:43     ` Thomas Koenig
2022-09-07 18:57       ` FX
2022-09-09 17:50         ` FX
2022-09-10 10:14           ` FX
2022-09-11  9:49             ` Mikael Morin
2022-09-11  9:57               ` FX
2022-09-11 10:23                 ` Mikael Morin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80F2E884-677E-4761-875A-082D853F913B@gmail.com \
    --to=fxcoudert@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).