From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2AC6C3858C78 for ; Mon, 11 Dec 2023 23:45:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2AC6C3858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2AC6C3858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702338317; cv=none; b=h7lC9UwWbDna3hYI01vOotJ4Ji4UNpnfpXHN8+xRbHlcMFFwCtcfDBuKUTxWzrohmkvGuEk2SQjkPZhqblacT4SQ7EgkFE0FiRd6NZCEG4ZTzxRsekW8A2xhFjw2pc06I9Xh+B+jkmZ3afd/20lTiWp1BBlhflVJ2uth9geh4IM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702338317; c=relaxed/simple; bh=A4vDxmbXWEE22fxrYIRUI+xGhXcNN9UfKhFqBY1XME0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EzuS/6+Nh+VvYP0Z7R+0+CPpXmy3/6liqgfBnNg/UdKWYUrPWhu0fNhm0mrxv3bXWhKHWeVJ7qedTPYIBIqzfHwF2x4og14ajA4pySBozd8++PMAiRI6ReRxkV2iHNhnZ5UsCtEmfSmhZRneOSLfUq1B6iGw0Fi+6HpKz06nbQE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702338315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EhwbJYf1uKs//ykZ1P+XKDSbzkkTFiEfHob05fYYRU0=; b=Ln5/d71mbAZbzC//wIoWqaNcCZQ8Hui3ydVs3OiSzaiXqmMW/BSdkLAHQzu0bptpteKKQJ CqYpPaAHsmGRNivc5z5OnbJwDgkSTtE1a2L3SLH8KoIyum3sIb+43EMWozaR2Nk0zSZuY7 4G7LQKVY70feJ7feIoaUK60KF2XCR70= Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-8X-7M0myPxOUB0_CQxgwWA-1; Mon, 11 Dec 2023 18:45:14 -0500 X-MC-Unique: 8X-7M0myPxOUB0_CQxgwWA-1 Received: by mail-yb1-f198.google.com with SMTP id 3f1490d57ef6-db547281f5dso5296824276.2 for ; Mon, 11 Dec 2023 15:45:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702338313; x=1702943113; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EhwbJYf1uKs//ykZ1P+XKDSbzkkTFiEfHob05fYYRU0=; b=UvWLQ/WJooB4NIZ6yObHWjxIjhJChk6CVez9jwh8ef9t7UeLjnHhEeYzJF4w5pTGoi l8RbdWMHk/dxjP3NNJFFjqV2Gi/WFQrsD8C2DfepMWLzKO7i2+AGk2RakbzCj2XaUak/ NQSMwngso/Ft0D51SqjqFtvHgRNiTUGbjik6NfToBXi9D8ORd5iKNtPfeXupldKEa+Ny r5XwrTU0df319t1MZikFH75Ce7CcPcfM8a+62oCxGE0j845/+aRE9pekFBStYvrq3Jpi tA8AoJw/FyAIb/4rG6qGg81q9NunSoAIXryb33xaEIg3rus4jhEOjZNVUmfzQTXYVA0A r9Nw== X-Gm-Message-State: AOJu0Yy9gkU2cV6CS1qzf5atTcQEWYHyrc78k9xQ/otwxrXLH/RTXX9K 2VBkS+PxnJe8fB5wq1NlmUUKhhQGdk7pOTmCo+2f23mCsQVW+DxrSI65L5qYRzPGCV8PXH7HMaB F6WdXH8AHkbkE X-Received: by 2002:a5b:7c2:0:b0:db0:2b47:aa1 with SMTP id t2-20020a5b07c2000000b00db02b470aa1mr3609682ybq.40.1702338313719; Mon, 11 Dec 2023 15:45:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGwaOc0jF3BCeU2JDHjRS5PMxnjyx/ztYV8eGESe+EytLHp9x3EF3ZMOD6RvPxRQUszqiFRhg== X-Received: by 2002:a5b:7c2:0:b0:db0:2b47:aa1 with SMTP id t2-20020a5b07c2000000b00db02b470aa1mr3609673ybq.40.1702338313457; Mon, 11 Dec 2023 15:45:13 -0800 (PST) Received: from ?IPV6:2607:fea8:51dd:2b00::115f? ([2607:fea8:51dd:2b00::115f]) by smtp.gmail.com with ESMTPSA id l2-20020ac848c2000000b00424030566b5sm3585343qtr.17.2023.12.11.15.45.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 15:45:13 -0800 (PST) Message-ID: <80e99500-163a-46be-96de-f35b2ee08e52@redhat.com> Date: Mon, 11 Dec 2023 18:45:11 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch] OpenMP: Minor '!$omp allocators' cleanup - and still: Re: [patch] OpenMP/Fortran: Implement omp allocators/allocate for ptr/allocatables To: Thomas Schwinge , Tobias Burnus , gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Cc: Jakub Jelinek References: <60940754-edc6-4110-b7ba-5bed2133bbb6@codesourcery.com> <87fs0bsjwx.fsf@euler.schwinge.homeip.net> <16bc2d0c-7228-43f8-803b-74a980510370@codesourcery.com> <878r60s81l.fsf@euler.schwinge.homeip.net> From: Andrew MacLeod In-Reply-To: <878r60s81l.fsf@euler.schwinge.homeip.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/11/23 17:12, Thomas Schwinge wrote: > Hi! > > This issue would've been prevented if we'd actually use a distinct C++ > data type for GCC types, checkable at compile time -- I'm thus CCing > Andrew MacLeod for amusement or crying, "one more for the list!". ;-\ Perhaps the time has come....  It is definitely under re-consideration for next stage 1... Andrew > (See > > "[TTYPE] Strongly typed tree project. Original document circa 2017".) > > On 2023-12-11T12:45:27+0100, Tobias Burnus wrote: >> I included a minor cleanup patch [...] >> >> I intent to commit that patch as obvious, unless there are further comments. >> OpenMP: Minor '!$omp allocators' cleanup >> --- a/gcc/fortran/trans-openmp.cc >> +++ b/gcc/fortran/trans-openmp.cc >> @@ -8361,8 +8361,10 @@ gfc_omp_call_add_alloc (tree ptr) >> if (fn == NULL_TREE) >> { >> fn = build_function_type_list (void_type_node, ptr_type_node, NULL_TREE); >> + tree att = build_tree_list (NULL_TREE, build_string (4, ". R ")); >> + att = tree_cons (get_identifier ("fn spec"), att, TYPE_ATTRIBUTES (fn)); >> + fn = build_type_attribute_variant (fn, att); >> fn = build_fn_decl ("GOMP_add_alloc", fn); >> -/* FIXME: attributes. */ >> } >> return build_call_expr_loc (input_location, fn, 1, ptr); >> } >> @@ -8380,7 +8382,9 @@ gfc_omp_call_is_alloc (tree ptr) >> fn = build_function_type_list (boolean_type_node, ptr_type_node, >> NULL_TREE); >> fn = build_fn_decl ("GOMP_is_alloc", fn); >> -/* FIXME: attributes. */ >> + tree att = build_tree_list (NULL_TREE, build_string (4, ". R ")); >> + att = tree_cons (get_identifier ("fn spec"), att, TYPE_ATTRIBUTES (fn)); >> + fn = build_type_attribute_variant (fn, att); >> } >> return build_call_expr_loc (input_location, fn, 1, ptr); >> } > Pushed to master branch commit 453e0f45a49f425992bc47ff8909ed8affc29d2e > "Resolve ICE in 'gcc/fortran/trans-openmp.cc:gfc_omp_call_is_alloc'", see > attached. > > > Grüße > Thomas > > > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955