Re: [PATCH] PR 78534, 83704 Large character lengths

["Dominique d'Humières" <dominiq@lps.ens.fr>]

I use x86_64-apple-darwin17 and I run the test with -m32. Without the patch, a plain compilation leads to four errors and a timing

0.011u 0.008s 0:00.02 50.0%	0+0k 0+0io 13pf+0w

With the patch I get the four errors plus "Result of LEN overflows its kind » and a timing much slower

12.454u 21.185s 0:35.29 95.2%	0+0k 0+0io 955pf+0w

Dominique

> Le 21 janv. 2018 à 12:11, Janne Blomqvist <blomqvist.janne@gmail.com> a écrit :
> 
> PING
> 
> On Sun, Jan 14, 2018 at 2:33 PM, Janne Blomqvist
> <blomqvist.janne@gmail.com> wrote:
>> On Sun, Jan 14, 2018 at 12:45 PM, Janne Blomqvist
>> <blomqvist.janne@gmail.com> wrote:
>>> On Sat, Jan 13, 2018 at 7:35 PM, Dominique d'Humières
>>> <dominiq@tournesol.lps.ens.fr> wrote:
>>>> I have finally bootstrapped gfortran with the two patches applied and the spurious warnings with -Wall are now gone (limited testing), but I see a regression for gfortran.dg/string_1.f90 due to an additional error
>>>> 
>>>> /opt/gcc/_clean/gcc/testsuite/gfortran.dg/string_1.f90:13:15:
>>>> 
>>>>   print *, len(s)
>>>>               1
>>>> Error: Result of LEN overflows its kind at (1)
>>>> 
>>>> No idea why this was not emitted without the patch.
>>> 
>>> Thanks for testing, I'll look into this. Was it on a 32 or 64-bit target?
>> 
>> I can't recreate this on i686-pc-linux-gnu. What host/target are you
>> using exactly, is it part of the normal testsuite run or do you
>> compile it with some special options?
>> 
>> In any case, that line isn't particularly relevant to what the
>> testcase is testing, so it could be removed completely, or by
>> specifying kind=8 to len().
>> 
>> 
>> 
>> 
>> --
>> Janne Blomqvist
> 
> 
> 
> -- 
> Janne Blomqvist