From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 8ED573858D37; Wed, 1 Feb 2023 12:12:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8ED573858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="96528617" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 01 Feb 2023 04:12:42 -0800 IronPort-SDR: 4vwFT+SgKnaFQ7EFb6b+arN56BXhpuLKAYcY/fitKj2YpZ50V4SGBKpZshn3Sj+xVR9We8tau1 M1Yrx7PxBI11ES8SWEp0XhzPn0cFKaKmI1kFbteFhh3OFHupHC07f4cS4mjkjZ7AVcRC1V+Zt0 WW8Bi9LUUQUX0+6jkHp7A/rnWYZojfpHhWg5bsT4uaDd5gbrQ6N4+5SoPPPOW24HJHQcF5iVb/ 05erLrMqe9RQXDuyyQqt9XPqtd0liLLDbyvRmzHad6SSxrAexCTOYsMUfmHa3eqOZ9g88tI8pq 7gE= Message-ID: <83e9a6eb-fa39-64fe-4bd8-c61a82068e58@codesourcery.com> Date: Wed, 1 Feb 2023 13:12:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [og12] Fix 'omp_allocator_handle_kind' example in 'gfortran.dg/gomp/allocate-4.f90' (was: [PATCH 1/5] [gfortran] Add parsing support for allocate directive (OpenMP 5.0).) Content-Language: en-US To: Thomas Schwinge , Hafiz Abid Qadeer , , CC: Jakub Jelinek References: <20220113145320.3153087-1-abidh@codesourcery.com> <20220113145320.3153087-2-abidh@codesourcery.com> <875yclppf8.fsf@euler.schwinge.homeip.net> From: Tobias Burnus In-Reply-To: <875yclppf8.fsf@euler.schwinge.homeip.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Thomas, On 01.02.23 12:59, Thomas Schwinge wrote: > + ! Don't do this (..., but it does pass the checks). > + !$omp allocate (var1) allocator(10_omp_allocator_handle_kind) ! { dg-b= ogus "Expected integer expression of the 'omp_allocator_handle_kind' kind" = } > + allocate (var1(x)) > + > + ! Assumtion is that 'omp_allocator_handle_kind' ('c_intptr_t') isn't 1= . > + !$omp allocate (var1) allocator(10_1) ! { dg-error "Expected integer e= xpression of the 'omp_allocator_handle_kind' kind at .1." } > allocate (var1(x)) s/Don't do this/Don't use a hard-coded value/ (or something like that) s/Assumtion/Assumption/ Otherwise, LGTM. (Especially it is both only a testcase and only on OG12.) Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955