From: Jeff Law <law@redhat.com>
To: Andrew Stubbs <andrew_stubbs@mentor.com>,
Andrew Stubbs <ams@codesourcery.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Fortran List <fortran@gcc.gnu.org>
Subject: Re: [PATCH 1/3] Create GCN-specific gthreads
Date: Wed, 19 Jun 2019 16:59:00 -0000 [thread overview]
Message-ID: <83f8c05e-4def-cd3e-a3bd-7703d75abd54@redhat.com> (raw)
In-Reply-To: <00a39060-8d8b-f835-e55d-2b3db75f9835@mentor.com>
On 6/19/19 10:56 AM, Andrew Stubbs wrote:
> On 19/06/2019 17:04, Jeff Law wrote:
>> On 6/19/19 2:57 AM, Andrew Stubbs wrote:
>>> Ping.
>>>
>>> I can probably approve this myself, as it only affects GCN, but I'd
>>> appreciate a second opinion.
>> Yes, this would fall under things you could approve yourself. Thanks
>> for double-checking.
>
> Sorry, I meant I'd like another opinion on the patch contents. I'm not
> confident that I didn't miss something.
The contents looked reasonable as well. The changes aren't going to
affect any other targets, so you can flesh them out over time as needed.
jeff
next prev parent reply other threads:[~2019-06-19 16:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 14:38 [PATCH 0/3] Enable full libgfortran for AMD GCN Andrew Stubbs
2019-06-07 14:39 ` [PATCH 1/3] Create GCN-specific gthreads Andrew Stubbs
2019-06-19 8:57 ` Andrew Stubbs
2019-06-19 16:04 ` Jeff Law
2019-06-19 16:56 ` Andrew Stubbs
2019-06-19 16:59 ` Jeff Law [this message]
2023-11-03 14:54 ` GCN: Address undeclared 'NULL' usage in 'libgcc/config/gcn/gthr-gcn.h:__gthread_getspecific' (was: [PATCH 1/3] Create GCN-specific gthreads) Thomas Schwinge
2019-06-07 14:40 ` [PATCH 2/3] Stub implementation of unwinding for AMD GCN Andrew Stubbs
2019-06-19 8:58 ` Andrew Stubbs
2019-06-19 16:05 ` Jeff Law
2019-06-19 16:57 ` Andrew Stubbs
2019-06-07 14:41 ` [PATCH 3/3] Enable full libgfortran library " Andrew Stubbs
2019-06-14 16:17 ` Janne Blomqvist
2019-06-19 16:05 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83f8c05e-4def-cd3e-a3bd-7703d75abd54@redhat.com \
--to=law@redhat.com \
--cc=ams@codesourcery.com \
--cc=andrew_stubbs@mentor.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).