From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 09D3C3858D37; Tue, 5 Apr 2022 04:12:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09D3C3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,235,1643702400"; d="scan'208";a="73849837" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 04 Apr 2022 20:12:43 -0800 IronPort-SDR: ugatGJxHq8XrgxGg+gVdqYVsnaokSWCN3t2zWdDSo3+RxGK7vrZvZShy18Zefs1FYsIf6kcyNP QLN9UOpk07CM82ACxrQV0biGnUp6sY2rvFanm6XCGQQbNoEavAJeyco1yXFj+AIpY4gFVEqVE7 C17HhLUNqzIPt030bJuCz9oHSMqIyz/jI+2k7KyK2odVsOzRwnJ6WCBlWJXQOXGfGsduuA7r5G TvEEsIAouN2UQKTVVLSQzj1NwL3/fZMf8cmeDm4E1aX8kw4PjS1opCUuo9B1UqlWB1q/VkKZUa sMQ= Message-ID: <8651a26f-7b51-a57c-d4a3-8aa5b2ddebb2@codesourcery.com> Date: Mon, 4 Apr 2022 22:12:33 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] Fortran: Add location info to OpenMP tree nodes Content-Language: en-US From: Sandra Loosemore To: "fortran@gcc.gnu.org" CC: "gcc-patches@gcc.gnu.org" References: <24bde0e8-8da4-4d4f-30fd-9a9b5830b944@codesourcery.com> In-Reply-To: <24bde0e8-8da4-4d4f-30fd-9a9b5830b944@codesourcery.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: svr-orw-mbx-13.mgc.mentorg.com (147.34.90.213) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2022 04:12:45 -0000 On 3/25/22 20:03, Sandra Loosemore wrote: > I've got another patch forthcoming (stage 1 material) that adds some new > diagnostics for non-rectangular loops during gimplification of OMP > nodes.  When I was working on that, I discovered that the Fortran front > end wasn't attaching location information to the tree nodes > corresponding to the various OMP directives, so the new errors weren't > coming out with location info either.  I went through trans-openmp.cc > and fixed all the places where make_node was being called to explicitly > set the location. > > I don't have a test case specifically for this change, but my test cases > for the new diagnostics in the non-rectangular loops patch do exercise > it.  Is this OK for trunk now, or for stage 1 when we get there? Ping! Even a quick review and "this isn't suitable for GCC 12" answer would be helpful. https://gcc.gnu.org/pipermail/fortran/2022-March/057706.html The definitely-stage-1 patch that exercises this is here: https://gcc.gnu.org/pipermail/fortran/2022-March/057707.html -Sandra