From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 8950F3858D20; Sun, 28 Jan 2024 19:56:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8950F3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8950F3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706471792; cv=none; b=a2Uj7e5lF7grTgfAdd/cLRcl8rTcJH4rrH3Pp18Eb1r81LBOW75BRTZY7NC8gDndOnO9uUofD8GYDPvoLPMXqT0eGV7vPszwE2+fXDJf4j5TDvriUtBZkACUgkSNA/7+2fATnl7ToSSRfNOY2stWXO2Ai7b915d+n+dR9C4Gkn0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706471792; c=relaxed/simple; bh=VBk04+JPKKcGwdG61VFIGL6tEkg0voWePummL30wz20=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=UuayYL5rU/triJy5WThofxEF3jwB6gN6Xsujni5UhS9ye83xndXAfvsvvu0ujHEjEn2KhBbQom4fgq04TbP2/N8I8zY6gWiMzMGP1HHdRNjchxZD3FEm5R6o74z9Fmg/jzslxYQV3RTihtxPgaEo1Nj+0oMo/TPj9a4OkO/uClw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1706471785; x=1707076585; i=anlauf@gmx.de; bh=VBk04+JPKKcGwdG61VFIGL6tEkg0voWePummL30wz20=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=Romc4H0AMza2cs5g5PH+46Y5o8p32owsGBSs4MRn+osNJjmnj2uA/rAM8SVU5HWo lXlf2L/DX+kgawsvXZBVYZidn1nOzCczcg0DLOB6vfM7HT0l9K+foMrn4/wszC8xO U4G7Q5XTbSQL1Mo9eCEPfj6QJX6ReJ2yvsUP+k9zhrq40/kNngMNccly8Ele2aVj2 56WRxVYi3wsBINX28cKP9ivt11BiD698GTrMwoDDE+bKQ2VfLutIB2tXuP0HLJ6re TPtTr6UUQJBoeQx5VYuaSbPk/5Bplt3a3Wv4N3yB1VWZDVNMDxRbbDzZdadqW9HMB hcqpwmISKFVvZoDprw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([79.251.8.180]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4zAy-1r2aFx0jbw-010uyI; Sun, 28 Jan 2024 20:56:25 +0100 Message-ID: <86888cc5-3650-4044-b67d-89aab1631753@gmx.de> Date: Sun, 28 Jan 2024 20:56:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fortran: use name of array component in runtime error message [PR30802] To: Mikael Morin , fortran , gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <67c77b44-79cb-4029-b59a-c92dfad15fa9@orange.fr> Content-Language: en-US From: Harald Anlauf In-Reply-To: <67c77b44-79cb-4029-b59a-c92dfad15fa9@orange.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ie1pMfUL4zDTRUyq1BMKzvYl3M+M2RgJcbum/ymKQTRe27zw7aY LySl/95dfTJdF4MhQlYAlPnmgtddk/i155ATcywqIbd/oOBACT0skoVt6R4vpkp8xtu7JFp 3dtnS+jyoTESdcvCNdswErQIi8XeKk6I2Y+i4qjFlTl1QNVL9LBLznBl8sJXxCtao8C0zJR 7VwnetlUUz5D7RVLc1KDg== UI-OutboundReport: notjunk:1;M01:P0:ra80cJo1GOo=;Pia9DVOPB3mbletUvnlo77lZa3K cyB3buw88flw2iONy/2aWDiYcMNuyUBDWBFsDU627AJqg79ytJj/0/NSB7vnF/8rTp27c/qjm aI+EoHTZbGhGuVMmgE+lq528vJw08sQ8sm0RoAodj3SkV/9N6+gg/e36bLX1r65doJvnAGF01 W2DkZNm7HUqN4HwJFa2hvZQQOXQxY9o4hc5atklpdNJdy+vQncY+EWa2/f4A+ux4dKX0BGM0l y3i63uN9jPIS5bX9mMP4E5n8qXlzIbmfxsQsFLMv6Tw0M26e5FB76yYspDQgN/vfF7WCNTz6E c/ISGqT9MpOD0WtXM5xB7Wx5GciGZFFPWSK3qkAgg2iy+HDDnXYStQnPlZCYqhCNLiuD+0OFD 5erBax9ihWLRa9vhO9zvCNfZJSYuEJLFmjOtCRl3GwUJsQ5tjYfTcndt2YMddBJABUtlbY+9Q sjtei9MxZYg/HRaz1vrWEPtiI7AZTCeNxXpq7LDswNGrTZPGqJHuFGCPAPWTDmQVYW4w/649E 2yf9toRIGscmhZcxnbOw6SbbGauaFBuTBIjByDuSOoejEsrZ/u5aj7fpUq8iz4AE3k+ex8XJg nb3Epx+BFVXwRNX0G/IFIIENt/7RdyxFbexmj9ADZ22Vs9ayCUf+fmso6OEnrFW5oT9QMw00F yhJ1WNqaJCJfk94/HdIBjPqchbIg6CuiQiSaFFIHEtfzn/NmlnL38JW6Jn5xFpK7f8i55VuoJ DHKHXaqYuDg50VkYaH9jBMtHElfsM21/OQ8TRBn3LJ2VN1EQwAGWCrqR+SrE11/PjcOjIz3fh +OTrR6sap03jslLApSW9iZdnMMly2JrI/q9vKWjyUC28cJvZPjVjzSDppLvdAei7GqCZxykgz tFqMUijMP2XoDrUiLRjx17CmVZbftIGOD/HNLvqhRk2nzPorPu3cGI9PfFRW4FNXrBetB25/b yhRcDOFhRuRXtOSNe2pUkRn4nv4= X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Mikael, Am 28.01.24 um 12:39 schrieb Mikael Morin: > Le 24/01/2024 =C3=A0 22:39, Harald Anlauf a =C3=A9crit=C2=A0: >> Dear all, >> >> this patch is actually only a followup fix to generate the proper name >> of an array reference in derived-type components for the runtime error >> message generated for the bounds-checking code.=C2=A0 Without the prope= r >> part ref, not only a user may get confused: I was, too... >> >> The testcase is compile-only, as it is only important to check the >> strings used in the error messages. >> >> Regtested on x86_64-pc-linux-gnu.=C2=A0 OK for mainline? >> >> Thanks, >> Harald >> > Hello, > > the change proper looks good, and is an improvement.=C2=A0 But I'm a lit= tle > concerned by the production of references like in the test x1%vv%z which > could be confusing and is strictly speaking invalid fortran (multiple > non-scalar components).=C2=A0 Did you consider generating x1%vv(?,?)%zz = or > x1%vv(...)%z or similar? yes, that seems very reasonable, given that this is what NAG does. We also have spurious %_data in some error messages that I'll try to get rid off. > There is another nit about the test, which has dg-output and > dg-shouldfail despite being only a compile-time test. I'll remove that. With gcc-13 the runtime check would trigger in the wrong line but the failure of the check is dealt with by another testcase in gcc-14. > Otherwise looks good. > > Mikael I'll come up with a revised patch. Thanks for the feedback so far! Harald