From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 22DBE3858D39; Tue, 4 Oct 2022 19:45:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 22DBE3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52c.google.com with SMTP id l22so18799405edj.5; Tue, 04 Oct 2022 12:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date; bh=cmin+1X/HFbH/ULUoYuTzIgRvqadntmN6fBuao1sZ1Q=; b=CmBi88WZrwGfsSNhsdPpIrcpjKsOReWYlCXoh13f2MWc5sScEd3L/xva4yGQp0l8jo v+JH+PYs57NHmY+qQ4ZZu20wdYWRiIvNasjUgoO0bZnu518HqwComUYq3vPpZ/Ayk6Xl om/BE5C3ZYy2az69JSu7U6ckjzDYkzKIov3GDmdX5y+V7kJzbC1VysEWlhvPBFyb0bIw uA5HMUIj1o4i1nX+Nqz/gBNYCuYk9uVfd1Qif7+fBr2JbokAcyI2drXQ+9iH0mWrrAvV /0ESNpvGlmYLIjo7DEwWC9psF3fA79URm8SeBWQj9elSDsEcEoGJIG5rr/r83zIdNQQ2 lyEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=cmin+1X/HFbH/ULUoYuTzIgRvqadntmN6fBuao1sZ1Q=; b=hMcdGKKpHXqlNMV7s6MLtlvQSqoF0QzumKk2HjWRbFa0JcYEhtOvcPmQ0pHD3O+H/+ X9IQiYjRzsMYjYF6+d6CELvXfOA1H3TRVDl952Kg9IEJFn59dy3fgwJlyYaQklnr6OLg lFLMBQoDxfLBWh+8JkHcW08cK5J9WV8Vd5+XLVkR485PN+U6qv7cVuGolXSD/fWdGokX NBuxuqfi705AoQ/vGOudHROrYro4egnsNelK1sgch4eal2rqzxT5G5d1Gfv3sQx2ZDcN qCpWJTRluGAT/0bKI7U4yTPO2V+TEx0yHVSplhoBmsz+oE4nN9mAYZwrllQAaj/AYhSR gGUg== X-Gm-Message-State: ACrzQf05eZqsa/g343nT9XKku2FlypL9Nlg945n2PI2w/ubi/0GZh6yM SKmVshWVM3BliEBUWFXewCmWzPnYrKE= X-Google-Smtp-Source: AMsMyM5ccwnQuJnxLWGy82xqhhOX7K8A46UTRIIw27xjOdBrHYZbXd3cvi+VbXYinEEoA/BiM3GnZQ== X-Received: by 2002:a05:6402:4cb:b0:453:b9f1:f10a with SMTP id n11-20020a05640204cb00b00453b9f1f10amr24921913edw.47.1664912706758; Tue, 04 Oct 2022 12:45:06 -0700 (PDT) Received: from ?IPv6:::1? ([2001:4bb8:101:7e28::2add:eb15]) by smtp.gmail.com with ESMTPSA id a11-20020a05640213cb00b00459091c44b3sm2295103edx.3.2022.10.04.12.45.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 12:45:05 -0700 (PDT) Date: Tue, 04 Oct 2022 21:45:00 +0200 From: Bernhard Reutner-Fischer To: LIU Hao , LIU Hao via Gcc-patches CC: fortran@gcc.gnu.org Subject: Re: Adding a new thread model to GCC In-Reply-To: <18773926-d861-0351-30e9-e7e1b832fc61@126.com> References: <0f1f223a-3756-1da3-bd1d-b87edd34e1f9@126.com> <7116A6F3-3968-4720-A65C-FFB05BFE181D@gmail.com> <7c519f0b-2a6d-e9bf-993a-2eff2cdad418@126.com> <0F33BB41-41EC-4068-84F1-9AD6DCCF190A@gmail.com> <18773926-d861-0351-30e9-e7e1b832fc61@126.com> Message-ID: <8720EB01-D0D0-41A4-A78D-54A39C8F13E4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4 October 2022 10:06:00 CEST, LIU Hao wrote: >=E5=9C=A8 2022-10-03 13:03, Bernhard Reutner-Fischer =E5=86=99=E9=81=93: >>=20 >> No, sorry for my brevity=2E >> Using __gthread_t like in your patch is correct=2E >>=20 > >I see=2E In 'libgfortran/io/async=2Ec' there is > > ``` > async_unit *au =3D u->au; > LOCK (&au->lock); > thread_unit =3D u; > au->thread =3D __gthread_self (); > ``` > >so indeed `thread` should be `__gthread_t`=2E Yes=2E > By the way I reported this issue four months ago and haven't received an= y response so far: > > https://gcc=2Egnu=2Eorg/bugzilla/show_bug=2Ecgi?id=3D105764 So, ideally, you would mention this PR in your patch=2E LGTM (obvious even) but I cannot formally approve it=2E thanks,